Absolutely, I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git. I did for so many and this file will get its turn soon.
The translatable text should not have beginning or end spaces. Space is not part of the translation it is part of the code. Also, it would be an even better idea to put it in the Variables.qml as a constant. Later we may categorize them all like Variables.rate : qsTr("mL/min") or Variables.pressure : qsTr("mmHg") and so. Please apply to all the other occurrences.
Thanks for the link. As you mentioned these are just example to make/teach some points and not necessarily are good codding practices. Please review twice to see if there is a better way. I'm not a fan of using states in QML code if is not absolutely necessary.
I see duplicate files names which should not be if the correct change sets have been chosen. I don't believe this code review is valid. Seems like Jira can't handle this correctly.
