Moved to MessagePayloads.h for now to reduce code in an already large module. These payload definitions will eventually be distributed to the various modules that will be sending/handling the associated messages.
This model is for a request, so we're not parsing data from CAN, only sending it out. There's no implementation of GetValue that works with QVariants. In other places in the code it's only used with QByteArrays.
For the new code, when you do the merge make sure that the message ID's are added to common/msg_defs.py instead of distributed to each class. I have an existing ticket http://dvm-linux02:8080/browse/DIAL-33 to read the message IDs and alarm IDs from common for older code.
"*** almost off the subject ***" it makes the parameter to be identified as a value, not a type. there is no preference for function argument naming in python coding style.
"*** Off the subject ***" Thanks for reminding that. This is exactly what I've told and mentioned while ago at the beginning of adding these methods as part of Dialin, that was the main reason we did it. As we talked while ago and you're the Dialin owner, please create a story for yourself and cooperate with our manager to define the priority/plan for the story. From that moment on, all the newly added methods shall follow that design and implementation.
This file has been replaced with its Camel Case version. But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch. So actually this file doesn't exist anymore.
There are tests (manually/automatically) for that and the application quits properly. If terminates by SquishCoco or being killed in the terminal may not have time to clean up correctly. When shuts down by user within the UI by user quits nicely and clean.
"** Also please don't check "Needs resolution" for every comment you make, it happened many times regardless of mentioning it multiple times ***"
Will use it in the next Story. I need to ask you how to use it and I would require testing the code again. Thanks for the help and suggestion it has been removed from here and used common in the testsuits.
fromVariantList is used to process a FW validation response from a QVariantList to the TreatmentParametersRespData. Did you think something should change in this function?
If not, could you be more specific about what is not expected?
You are running release
CR4.8.14
FE4.8.14
(20240111091859 2024-01-11 09:20),
please report your release number when reporting bugs.
