make the tst_view your class friend. so it will have access to the private members of your class. Please read the existing code thoroughly and see how some issues have been solved and please do not reinvent the wheel.
"********* I must emphasize that making a class a friend of the other is only allowed for test classes. *********" And also please do these tests in SquishQt, not in C++, look at the next commit.
Please put a short description of your component and explain what it does and where it can be used. Since it is a specific or compound component and is not a general component like a just a Slider or Progressbar, it helps to understand the use case of the component.
Please put a short description of your component and explain what it does and where it can be used. Since it is a specific or compound component and is not a general component like a just a Slider or Progressbar, it helps to understand the use case of the component.
"*** Off the subject ***" I don't have any plans for that. It was an effort to feel the gap of not having the corresponding FW code at that moment. If it happens again will consider improving the code otherwise we need to consolidate with our manager for priorities/planning.
"*** Off the subject ***" This code review is about the documentation, not the code change. There is no implementation and unit testing associated with this story.
If .toFixed(2) indicates that we want to display 2 decimal places, these first 6 values are in gravities - likely between -1 and +1 - and so I'd like to see these with 3 decimal places.
Hey Peter, You're right I removed them to easier do the merge. Since the task DEN-4690: Doxygenization has been changed to story and there is a code review sub-task for that, let's address all the documentation in that stoy.
Hey Peter, You're right I removed them to easier do the merge. Since the task DEN-4690: Doxygenization has been changed to story and there is a code review sub-task for that, let's address all the documentation in that stoy.
This is from Dara's HD valves branch. I pulled his FPGA module because he did the last update for register alignment with latest FPGA version, but now that I'm trying to wrap up dev testing, I don't want to duplicate effort to test these functions. All I really needed from the pull was the register map - should have deleted these right after the pull.
