•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-4322-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

Align all comments under each other vertically.

DIALIN-DEN-4169-1 09 Sep 2020

RESOLVED.

UI-DEN-3605-4 09 Sep 2020

Remove extra line.

HD-DEN-4640-1 05 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 05 Oct 2020

As we talked it still needs some other mods.

HD-DEN-4308-3 22 Sep 2020

Done

DIALIN-DEN-4308-1 30 Sep 2020

Done

HD-DEN-5053-1 22 Sep 2020

Done.

HD-DEN-5053-1 22 Sep 2020

Done.

UI-DEN-3605-4 06 Oct 2020

This change fixes a bug in the slider component when the step (resolution) is set to 1. If a step of 1 is used the set value improperly contains 14 decimals instead of being in increments of 1.
Let me know once you've looked into it more and how you'd prefer that issue to be fixed.

HD-DEN-5053-1 22 Sep 2020

Done.

HD-DEN-5053-1 22 Sep 2020

Done.

DIALIN-DEN-4690-1 07 Oct 2020

RESOLVED

HD-DEN-4308-3 23 Sep 2020

Done

HD-DEN-5053-1 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4690-1 07 Oct 2020

Doesn't indicate when true is returned

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 22 Sep 2020

No abs() here either.

UI-DEN-3605-4 30 Sep 2020

Why this class is included.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 22 Sep 2020

Comments need to be a little more verbose. I can't tell what these variables are for based on comments. Use /// on line above if you need more room.

DIALIN-DEN-5053-1 30 Sep 2020

These message IDs should also be in common

HD-DEN-4308-3 23 Sep 2020

Add () to clarify order of precedence. Remove #ifdef on door closed.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 07 Oct 2020

I looked into implementing what you suggest and it would require modification of both _FileSaver and _FileHandler to work properly.
You've discouraged modifying the production code to make the tests work in the past. We would definitely need to modify the production code in this case to get the test to work as you describe.
Also, does it make sense to make tst_views.cpp a friend of the FileSaver class?
Please remember this is test code not production code, and that the test is already completely functional, working, and passing.
Can you point me to a place in our coding standard that discourages using QThread in non-production test code?

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Oct 2020

Remove extra colon : between param and rpm and new.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4308-1 28 Sep 2020

Align with left "(".

TESTSUITES-DEN-3724-1 07 Oct 2020

Why this is added?
The unit test for that feature was working and all the tests and coverage passed.
Why it has been modified?
Please remove it.

UI-DEN-3605-4 30 Sep 2020

Why this class included?

DIALIN-DEN-4690-1 07 Oct 2020

"*** Off the subject ***"
This code review is about the documentation, not the code change.
There is no implementation and unit testing associated with this story.

DIALIN-DEN-4690-1 07 Oct 2020

"*** Off the subject ***"
This code review is about the documentation, not the code change.
There is no implementation and unit testing associated with this story.

DIALIN-DEN-4690-1 07 Oct 2020

"*** Off the subject ***"
This code review is about the documentation, not the code change.
There is no implementation and unit testing associated with this story.

DIALIN-DEN-4690-1 07 Oct 2020

Please add the return type and fill in the parameter descriptions

UI-DEN-3605-4 09 Sep 2020

I looked into subclassing MAbstract at the time and again today but there's some incompatibility there that needs to be worked through.
How about I work on subclassing MAbstract in my current story? I don't think it would be good to change too much structure against these revisions as the code has been sitting for awhile and other things have changed quite a bit. Also, I think the MAbstract class may have been added near the end of my development on DEN-3605.
I'd like to make sure our models and code structure are all aligned too. I think it's better to do that on the latest code rather than the branch this code is sitting on which is outdated at this point.

UI-DEN-3605-4 28 Aug 2020

Remove 2 extra lines.

UI-DEN-3605-4 28 Aug 2020

Remove extra line.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

DG-DEN-5963-1 03 Apr 2021

I rephrased it.

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5381-1 17 Dec 2020

Moved to common AlarmDefs.h.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4690-1 09 Sep 2020

RESOLVED.