This change fixes a bug in the slider component when the step (resolution) is set to 1. If a step of 1 is used the set value improperly contains 14 decimals instead of being in increments of 1. Let me know once you've looked into it more and how you'd prefer that issue to be fixed.
I looked into implementing what you suggest and it would require modification of both _FileSaver and _FileHandler to work properly. You've discouraged modifying the production code to make the tests work in the past. We would definitely need to modify the production code in this case to get the test to work as you describe. Also, does it make sense to make tst_views.cpp a friend of the FileSaver class? Please remember this is test code not production code, and that the test is already completely functional, working, and passing. Can you point me to a place in our coding standard that discourages using QThread in non-production test code?
"*** Off the subject ***" This code review is about the documentation, not the code change. There is no implementation and unit testing associated with this story.
"*** Off the subject ***" This code review is about the documentation, not the code change. There is no implementation and unit testing associated with this story.
"*** Off the subject ***" This code review is about the documentation, not the code change. There is no implementation and unit testing associated with this story.
I looked into subclassing MAbstract at the time and again today but there's some incompatibility there that needs to be worked through. How about I work on subclassing MAbstract in my current story? I don't think it would be good to change too much structure against these revisions as the code has been sitting for awhile and other things have changed quite a bit. Also, I think the MAbstract class may have been added near the end of my development on DEN-3605. I'd like to make sure our models and code structure are all aligned too. I think it's better to do that on the latest code rather than the branch this code is sitting on which is outdated at this point.