•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4964-1 13 Oct 2020

Our C++ coding standard calls for the first "{" to be opened in the same line as the class/function definition. I will change.

Addressed. I have also asked BehrouzN to run Qt Beautifier to make all of these consistent throughout the UI Application code base.

UI-DEN-4964-1 13 Oct 2020

The v prefix is not informative / needed

From the C++ coding standard:
"4. Functions and variables should have descriptive and meaningful names or well-commented declarations; variables with a small scope can have short names."

DIALIN-DEN-11980-1 16 Feb 2022

RESOLVED.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

DG-DEN-5963-1 04 Jan 2021

Shouldn't these functions return a boolean? Then assign result to return value instead of always TRUE.

HD-DEN-5674-2 30 Dec 2020

I do not yet know what the actual volume of our venous line is.

DG-DEN-3504-1 02 Nov 2020

Done.

DG-DEN-5963-1 04 Jan 2021

In HD, AlarmDefs.h is always included via common.h which includes AlarmMgmt.h which includes AlarmDefs.h. DG should be same way so you shouldn't need to include it here.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 08 Apr 2021

Preferred architecture is to just set flag here and then let your state machine see the flag and change the state and command the fpga when it next executes.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-9480-1 11 Nov 2021

RESOLVED.

DG-DEN-3504-1 02 Nov 2020

Done.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6080-1 28 Dec 2020

Suggest using a local variable to store target drain pump RPM value to avoid calling the same function twice.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 29 Dec 2020

Added TODO instead.

DG-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

UI-DEN-4598-1 03 Nov 2020

Done

UI-DEN-4964-1 29 Dec 2020

Changed Event to Datum for both DG and HD *.h files.

UI-DEN-4598-1 03 Nov 2020

Done

UI-DEN-4598-1 03 Nov 2020

Done

HD-DEN-5674-2 30 Dec 2020

Fixed.

UI-DEN-4598-1 04 Nov 2020

Done

UI-DEN-4598-1 03 Nov 2020

please remove this.
As explained tests should not be in the tst_canbus and should be in tst_models.

HD-DEN-5674-2 30 Dec 2020

we have (formal) instead of we've (informal)

UI-DEN-4598-1 09 Nov 2020

RESOLVED

UI-DEN-4598-1 01 Nov 2020

Please document why this file is created.
And Please move it to its appropriate folder "./sources/gui/qml/components".
And also this component seems unnecessary since it's so small and looks like being used only for one purpose, so please move it in the main component it has been used for.

UI-DEN-4598-1 01 Nov 2020

If this class is the Treatment Parameters Request, please refactor the class and file names to TreatmentParametersRequest to be more clear since this is the first class which has its own separate request class.

HD-DEN-5674-2 30 Dec 2020

Done.

UI-DEN-4598-1 09 Nov 2020

RESOLVED

DIALIN-DEVELOP-BUG-FIXES-1 04 Nov 2020

Spell out Fld to understand variable name

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 16 Dec 2020

this message has zero length by definition.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 03 Jan 2021

Addressed.

UI-DEN-4964-1 03 Jan 2021

Addressed.

UI-DEN-4964-1 16 Dec 2020

Please add the same messaging documentation for your new message container models should be like below (only for your new message, the others are already added):

/*!
 * \brief   The MAdjustDurationReq class
 * \details The treatment duration change request model
 *
 * | MSG  | CAN ID | Box | Type   | Ack | Src | Dst | Description                       |
 * |:----:|:------:|:---:|:------:|:---:|:---:|:---:|:-----------:                      |
 * |0x1600| 0x100  | 9   | Req    | Y   | UI  | HD  | Treatment Duration Change Request |
 *
 * | Payload  ||
 * |          ||
 * | #1:(U32) | \ref duration |
 *
 */
HD-DEN-5674-2 30 Dec 2020

we are (formal) instead of we're (informal)

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Align comments and numbers.

DIALIN-DEN-5674-2 06 Jan 2021

I don't have that class in my branch.

UI-DEN-6349-1 08 Jan 2021

Why does it even need styling?
Couldn't we use the keyboard default styling?
Please provide two of the default and styled screenshot versions of the keyboard for comparison.

UI-DEN-6349-1 12 Jan 2021

It still applied to the newly created file.
I would prefer to have something more general like:

  • TextEntry
    And please don't use a name like "Denali" which is subject to change.
UI-DEN-5830-2 12 Jan 2021

I only wanted to exclude them from coco, but for some, I had to completely comment them, but still kept the ones that don't require to be commented.

DIALIN-DEN-6078-1 14 Jan 2021

Remove extra lines.

UI-DEN-6349-1 12 Jan 2021

Done

UI-DEN-6349-1 12 Jan 2021

Done