•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 18 Jan 2021

RESOLVED

UI-DEN-6349-1 19 Jan 2021

RESOLVED.

UI-DEN-4690-2-1 07 Oct 2020

It is all documentations and Doxygenization.
If you see otherwise is because of the some file name change and the code review take it as a new file and mark all the file content as to be reviewed.
Let me know if otherwise.

HD-DEN-7395-1 12 Apr 2021

Addressed.

DG-DEN-3504-1 02 Nov 2020

Done.

UI-DEN-4964-1 14 Oct 2020

Left is reserved for another HD item already and top is reserved for DG data. Regardless, once all the visual elements of acceleration and versioning are added to the UI, we will be going through a real estate optimization exercise to ensure best positioning given the limited amount of space in one screen.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 02 Nov 2020

Missing function header.

HD-DEN-5674-2 30 Dec 2020

it is (formal) instead of it's (informal)

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

this notification bar shall not be confused with the alarm notification bar.

  • these are showing specific rejection reasons related to each screen request. and resides on that one. Which may even in some cases be covered by a higher priority alarm.
  • Alarm bar is a general bar on the screen that shall always be visible regardless of the screen we are currently in.
    These two may exist at the same time and alarm may even cover those rejection requests.
DG-DEN-6080-1 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 03 Nov 2020

Done

DIALIN-DEN-6018-2 28 Dec 2020

RESOLVED.

UI-DEN-4598-1 04 Nov 2020

RESOLVED.

UI-DEN-4598-1 29 Oct 2020

Remove extra space.

UI-DEN-4598-1 03 Nov 2020

Should be "event" only broadcasts are "datum"

DIALIN-DEN-4640-1 09 Nov 2020

RESOLVED.

UI-DEN-5751-1 01 Feb 2021

Cannot find this line in the code.
May have been removed already.

UI-DEN-4598-1 09 Nov 2020

RESOLVED

UI-DEN-4598-1 09 Nov 2020

RESOLVED

UI-DEN-4598-1 09 Nov 2020

RESOLVED

UI-DEN-4598-1 01 Nov 2020

Please use "handler" instead of "knob" to be consistent with the rest of the code.
And also please move it next to "handler" on line 38.

UI-DEN-4598-1 09 Nov 2020

RESOLVED

HD-DEN-4641-1 01 Dec 2020

No more flexibility on duration/frequency of this particular alarm needed?

UI-DEN-4691-1 09 Nov 2020

Remove extra line.

UI-DEN-4964-1 16 Dec 2020

These two lines are not correct/required since this message doesn't have a payload at all.
Just keep the LOG_EVENT

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

DIALIN-DEN-5638-1 30 Dec 2020

As of 12/30/2020, with these changes:
Code Coverage: 100%
Squish Tests Passing: 100%

HD-DEN-5887-1 29 Dec 2020

runs instead of run

HD-DEN-4641-1 01 Dec 2020

When using "==" with a literal, I always put the literal first so that if I accidentally use "=" the compiler will throw a syntax error.

HD-DEN-5674-2 29 Dec 2020

Remove extra line.

HD-DEN-4641-1 01 Dec 2020

Done.

HD-DEN-5674-2 29 Dec 2020

Remove extra line.

HD-DEN-5674-2 29 Dec 2020

Add TODO to remember to either uncomment or delete the lines below.

UI-DEN-5736-1 01 Dec 2020

Done

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

PWM should be changed to duty cycle.

HD-DEN-4641-1 01 Dec 2020

TODO is for reminders to do something later. TBD is for something that is unknown for now. I would prefer keeping them separate, but if I had to consolidate to one I would rather use TODO.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

Done.

HD-DEN-5674-2 30 Dec 2020

Formalize sentence.

DG-DEN-5873-1 01 Dec 2020

No it is not. I brought the case into the #ifdef.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5736-1 03 Dec 2020

This should be #4

UI-DEN-5751-1 01 Feb 2021

if it is a constant/read-only value that will be used mostly in qml, then better to be defined in QML unless otherwise required.