•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5873-1 01 Dec 2020

This has been renamed. It will be added to the RO pump branch.

DG-DEN-5873-1 02 Dec 2020

Done

HD-DEN-7091-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5736-1 03 Dec 2020

RESOLVED.

DG-DEN-5855-1 03 Dec 2020

Done. Sorry I don't know what happened to this header.

DG-DEN-5864-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 03 Jan 2021

Addressed.

DG-DEN-5846-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5864-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 03 Jan 2021

Please change it to "DGAccelData" as you have stated in the infoText function. this should be exactly the text user may search for in the log file to find the logged message.

UI-DEN-4964-1 05 Jan 2021

RESOLVED

DG-DEN-3421-2-1 07 Dec 2020

Done

UI-DEN-6349-1 08 Jan 2021

Please don't use ";" until it's absolutely necessary, especially in qml codes.

UI-DEN-5830-2 12 Jan 2021

Actually, No this is in the correct place and those two other components shall cover the minimize mouseArea.
IF it goes last then it covers those two and they will never work.

UI-DEN-6349-1 13 Jan 2021

Done

DG-DEN-6200-1 15 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 08 Jan 2021

please use "Item" instead of "Rectangle" with color as transparent when possible.

DG-DEN-3504-1 02 Nov 2020

Done.

DIALIN-DEN-3421-1 07 Dec 2020

Use DialinEnum, remove has_value as it already exists in the DialinEnum parent class

DG-DEN-3504-1 02 Nov 2020

Done.

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 04 Jan 2021

Add TODO on this to restore condition later.

DG-DEN-8030-1 13 Jun 2021

Done

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6080-1 29 Dec 2020

Done

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

HD-DEN-5381-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-11980-1 16 Feb 2022

RESOLVED.

HD-DEN-4641-1 01 Dec 2020

Fixed.

HD-DEN-5381-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 02 Nov 2020

Reverted now, sorry about that.

When I added left and right margins to the mouse area in RangeRect to make it easier to select the knob from the left of a slider or the right of the slider when the knob was at its minimum or maximum position, the unintended consequence is that there is sometimes an offset between the click point and the knob position, requiring small adjustment to tests using sliders.
I've removed that change to RangeRect now and reverted the values here back to 190. I think a better solution would be needed if we still want to expand the left and right mouse area touch margins of the slider.

UI-DEN-4964-1 29 Dec 2020

Also addressed in VTreatmentAdjustDG/HDVersions.h.

UI-DEN-5751-1 01 Feb 2021

Actually, this feature (Arterial/Venous Pressure) was done before Pre-Treatment Create feature.
At the moment Pre-Treatment Create has been implemented existence of these parameters has been ignored and another approach has been followed.
In general, If a simple value can be defined in where it is being used the most (in this case qml) it's better to be defined there and not to call multiple setter, getter for getting a simple read only value.

UI-DEN-4598-1 02 Nov 2020

Reverted back now
(See above)

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5864-1 30 Nov 2020

Add TODO here.

UI-DEN-4598-1 03 Nov 2020

RESOLVED

HD-DEN-5674-2 30 Dec 2020

Implemented TODO. Removed comment.

UI-DEN-4598-1 03 Nov 2020

RESOLVED

HD-DEN-6402-1 01 Feb 2021

Any reason why pause state can't be part of patient connection state?

DIALIN-DEN-6078-1 22 Feb 2021

These still need to be updated
outer_instance can be removed, and can_interface needs to be added. the logger parameter description isn't right as the deprecated outer_instance parameter was a reference to the DG (outer) class, not the logger parameter

DG-DEN-5980-1 22 Feb 2021

Why commented out?