•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-5283-1 19 Oct 2020

That's the vertical alignment of values for the same category variables to find assigned values easily.
Enhance readability. The assignments are easier to spot compare to each other.

HD-DEN-5053-1 15 Oct 2020

This reset is generated by the application software writing a 1 to bit 15 of System Exception Control Register (SYSECR) or a 0 to bit 14 of SYSECR.
This shift will write a 1 to bit 18 and 0 to the rest. Probably still work since it still writes a 0 to bit 14, but we might as well assign 0x0 to this register.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 09 Nov 2020

RESOLVED

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEVELOP-BUG-FIXES-1 04 Nov 2020

Spell it Fld to understand the variable name

DIALIN-DEN-3504-1 09 Nov 2020

I'm not convinced we can change modes via Dialin command. For one thing, many mode transitions are illegal and will cause a system fault. But even if mode change is legal, changing via external command bypasses internal state machine constraints and workflow leaving you in a new mode without proper context.

HD-DEN-5887-1 29 Dec 2020

Why were these deleted?

DG-DEN-3421-2-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Do not (formal) instead of don't (informal)

UI-DEN-5736-1 01 Dec 2020

done,
Sure from now on.

HD-DEN-5674-2 30 Dec 2020

Do not (formal) instead of Don't (informal)

UI-DEN-5736-1 01 Dec 2020

done,
Sure from now on.

DG-DEN-8030-1 13 Jun 2021

Done.

DG-DEN-3421-2-1 01 Dec 2020

Done

DIALIN-DEN-6018-2 28 Dec 2020

They are commented out so the console output only contains the requirements I'm interested in

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5864-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6080-1 29 Dec 2020

Done

DG-DEN-6080-1 29 Dec 2020

Done

DG-DEN-5846-1 07 Dec 2020

Mismatch function names.

HD-DEN-5381-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5381-1 17 Dec 2020

If commented code, either remove it or add TODO comment to remember to either uncomment it or delete it in the future.

UI-DEN-5830-2 12 Jan 2021

I have different types of comments one of them is "// DEBUG:" which we don't have a todo item for that.
It only exists for later or in casede bugging that I don't want to log with that format all the time but sometimes useful for debugging.

UI-DEN-5830-2 12 Jan 2021

Kept it as a place holder to keep all 16 bits visibly used.

UI-DEN-6349-1 08 Jan 2021

Please change the file name to TextEntry or TextEdit to make it more general (but not TextInput which conflicts with QtQuick).
Field most of the time refers to a database field which is not the case all the time for this component.

UI-DEN-6349-1 13 Jan 2021

Done - see TextEntry.qml

UI-DEN-6349-1 13 Jan 2021

Semicolons have been removed

UI-DEN-6349-1 12 Jan 2021

Done

UI-DEN-5830-2 13 Jan 2021

RESOLVED

DIALIN-DEN-5830-2 13 Jan 2021

Good catch, thanks.
Removed.
It seems SquishQt tries to add packages and when I am going to use 'utils' without importing it, SquishQt tries to import it but from the wrong package.

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-6349-1 08 Jan 2021

Where the color has been picked from?
If it is from UX design from zeplin, keep that in mind it wasn't a final design and has been put there to imply that the page requires a keyboard.
what is the default color?

UI-DEN-6349-1 08 Jan 2021

Please don't forget the translation for all the translatable strings.

DG-DEN-8030-1 13 Jun 2021

This was for testing. It is uncommented.

UI-DEN-4964-1 14 Oct 2020

Will do.

Let's all agree to do it this way moving forward. I like the arrangement of files in their corresponding buckets, denali.pro looks much cleaner this way.

UI-DEN-4964-1 14 Oct 2020

Will do.

Let's all agree to do it this way moving forward. I like the arrangement of files in their corresponding buckets, denali.pro looks much cleaner this way.

UI-DEN-4964-1 02 Nov 2020

Updated DG/HD accelerometer data class headers, and will apply this header concept for DG/HD version data moving forward.

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED

HD-DEN-5381-1 17 Dec 2020

Should be an elseif?

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED.

DIALIN-DEN-3504-1 09 Nov 2020

RESOLVED

DIALIN-DEN-4690-1 14 Oct 2020

Fair, not part of story.

RESOLVED

UI-DEN-4690-1 14 Oct 2020

RESOLVED.

UI-DEN-4598-1 09 Nov 2020

RESOLVED

TESTSUITES-DEN-3724-1 14 Oct 2020

Done

UI-DEN-4598-1 03 Nov 2020

Sure, makes sense. I removed the ProgressLine component and will keep that in mind going forward before adding any new components