•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4598-1 03 Nov 2020

Done. I don't think there is a use for a count right now? Let me know if you still want a count

LEAHI-TD-FIRMWARE-LDT-1903-8 24 Feb 2026

0.0F

DG-DEN-6080-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 03 Dec 2020

Done

DG-DEN-6080-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6080-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5381-1 17 Dec 2020

Where were these moved to?

DG-DEN-5846-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 22 Feb 2021

Why did this file change?

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 29 Dec 2020

Done.

DG-DEN-6081-1 29 Dec 2020

I added a persistent alarm.

HD-DEN-5674-2 29 Dec 2020

Remove extra line.

HD-DEN-5674-2 29 Dec 2020

Remove extra line.

UI-DEN-5638-1 30 Dec 2020

As of 12/30/2020, with these changes:
Code Coverage: 100%
Squish Tests Passing: 100%

HD-DEN-5887-1 30 Dec 2020

Moved to AlarmDefs.h in common. Dara, please add common repo to this code review.

HD-DEN-5887-1 30 Dec 2020

Fixed.

HD-DEN-5674-2 30 Dec 2020

we have (formal) instead of we've (informal)

UI-DEN-6349-1 08 Jan 2021

same here.

UI-DEN-4860-BLE-1 12 Jan 2021

please don't use the clip, it is not recommended.
Also, there should not be an issue with the silent button, it has been tested!
What are you trying to achieve?

UI-DEN-6349-1 13 Jan 2021

How come a function has been added in the cpp but the header is not automatically added to the code review?

UI-DEN-4860-BLE-1 13 Jan 2021

"connmand" is correct
It's used to manage internet connections on embedded devices and causes problems if it is already running while bluetooth is starting up

UI-DEN-4860-BLE-1 13 Jan 2021
UI-DEN-6349-1 08 Jan 2021

please use #pragma once

DG-DEN-6200-1 15 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 08 Jan 2021

Where these values come from and please define them in the Variables file under the PRS section if applicable?

UI-DEN-6349-1 08 Jan 2021

same here.

DIALIN-DEN-3421-1 07 Dec 2020

Use DialinEnum for these, delete has_value, as it's in DialinEnum

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED.

Fair, not part of story

UI-DEN-4690-1 14 Oct 2020

RESOLVED.

DIALIN-DEN-3504-1 02 Nov 2020

This is a part of DEN-4640. It has been fixed in the latest develop branch.
MSG_ID_UI_ALARM_ACKNOWLEDGE has been removed and replaced with MSG_ID_UI_ALARM_USER_ACKNOWLEDGE.

UI-DEN-4690-2-1 14 Oct 2020

RESOLVED

HD-DEN-7395-1 12 Apr 2021

Addressed.

UI-DEN-3605-4 14 Oct 2020

RESOLVED

UI-DEN-4598-1 03 Nov 2020

RESOLVED

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

DG-DEN-5963-1 04 Jan 2021

Is ppiPressure being checked here or in global check I saw at top of exec? Since VPi is closed for much of this mode, the global check is probably not right.

UI-DEN-4964-1 29 Dec 2020

Done.

DIALIN-DEN-3504-1 04 Nov 2020

The alarm ids can be obtained directly from AlarmList class in dialin/common/alarms_defs.py.

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

UI-DEN-4964-1 14 Oct 2020

Addressed.

DG-DEN-5873-1 01 Dec 2020

I brought the case to be inside #ifdef.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.