•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4860-BLE-1 14 Jan 2021

RESOLVED

UI-DEN-6349-1 08 Jan 2021

why QtQuick.Controls imported?

UI-DEN-4690-1 16 Sep 2020

"*** Off the subject ***"
At the time of testing application with SquishCoco, observed that Coco can't safely quit application and terminates the application and don't call the correct quit method of the application and that makes sense since the Squish Coco is another application and will immediately terminate the UI application and don't know how to properly quit the UI application.
So UI application can't safely quit the threads.
Therefore some threading features has been manually tested.
The quitThread in each class is basically should name moveThread (move to main thread).

I hope this is enough information !

DIALIN-DEN-3421-1 07 Dec 2020

super()._init_() is missing

UI-DEN-4598-1 01 Nov 2020

Thanks for this effort.
If this and the other scripts are the implementations regarding the "SquishQt headless server" in the following link https://kb.froglogic.com/squish/howto/using-squish-headless-systems/
Please work with Dara Navaei to implement this on the server as well regarding the conversation Dara and I had a while ago and he is already aware of it.

UI-DEN-4598-1 02 Nov 2020

Just one space between parameters.

UI-DEN-4964-1 14 Oct 2020

Based on my review of the QObject classes underneath, the whole intent of the VIEW_DEF and VIEW_DEC macros is to provide a much more simplistic interfaces to the user when wanting to create views and their corresponding data. We also made the decision to not touch these two macros. Hence, my expectation is for all features implemented moving forward to follow this design pattern.

Note: If someone wants to look at the definition of these macros, they can always go back to their corresponding *.h.

DG-DEN-3504-1 02 Nov 2020

Don't we need a #define for these values?

DG-DEN-3504-1 30 Oct 2020

Why removed?

DG-DEN-7802-1 10 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13427-1 07 Sep 2022

Fixed. Thanks!

UI-DEN-4964-1 14 Oct 2020

Definitions:
m is used for model data (structure) variables

Moving forward, my expectation is for all of us to follow the same naming convention. I have also requested BehrouzN to update the C++ Coding Standards.

UI-DEN-4964-1 14 Oct 2020

BehrouzN has addressed headers for all Data on Master Branch as part of the doxygenization effort.

HD-DEN-5381-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 04 Nov 2020

RESOLVED.

DG-DEN-8030-1 13 Jun 2021

Done.

HD-DEN-7091-1 22 Mar 2021

Fixed.

UI-DEN-4598-1 04 Nov 2020

Done

UI-DEN-4598-1 02 Nov 2020

Each reject reason (or none if no rejection) corresponds to a treatment parameter.
Since there was no need to duplicate the lines for each parameter, I've now updated it so they are generated using list comprehension instead.
Also I added the docstrings that were missing.

HD-DEN-5381-1 17 Dec 2020

It is at the beginning of Prime sub-mode.

UI-DEN-4598-1 03 Nov 2020

Please put Data:: scope resolution like the first one otherwise in Doxygen link is broken.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5873-1 02 Dec 2020

Done

UI-DEN-5736-1 03 Dec 2020

RESOLVED.

DG-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

UI-DEN-5736-1 03 Dec 2020

RESOLVED.

DG-DEN-5855-1 03 Dec 2020

Done

HD-DEN-5674-2 29 Dec 2020

Moved to AlarmDefs.h in common as there is need to update this table when new enum is added.

DG-DEN-5864-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5887-1 29 Dec 2020

Has this been changed by manually?

HD-DEN-5674-2 29 Dec 2020

Do we start comments with capital or not? Need consistency.

HD-DEN-5674-2 29 Dec 2020

Why were these all deleted?

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Why TODO?

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

UI-DEN-4964-1 16 Dec 2020

Since added one more parameter ( one F32, 4 bytes) in the payload of each messages the length should reflect the exact amount of the bytes and it needs to be changed to 8 * 4 for both of the :
Gui::GuiActionType::ID_BloodFlow , Gui::GuiActionType::ID_DialysateInletFlow
otherwise ui will read only 7*4 bytes and you will get zero for the last parameter (signal strength).

UI-DEN-4964-1 03 Jan 2021

RESOLVED

UI-DEN-4964-1 16 Dec 2020

This is a broadcast message and should be Datum as you have mentioned in the function typeText() method correctly.

UI-DEN-4964-1 03 Jan 2021

RESOLVED

HD-DEN-5674-2 30 Dec 2020

its instead of it's