•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED.

Fair, not part of story.

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED.

Fair, not part of story.

HD-DEN-5381-1 17 Dec 2020

Removed.

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED.

HD-DEN-5381-1 17 Dec 2020

Moved into its own state.

UI-DEN-4690-1 14 Oct 2020

RESOLVED

HD-DEN-4641-1 01 Dec 2020

Quang changed the way persistent alarms work (from task interval counts to ms). So task interval is no longer needed to determine when an alarm condition has persisted for too long.

UI-DEN-4690-1 14 Oct 2020

RESOLVED.

UI-DEN-3605-4 06 Oct 2020

Please revert this back.
It's not always an integer and as you may noticed value is the alias for the _progressRect.value and if you go inside the ProgressRect the value is real and not an integer.
Please think about the rest of the code when changing a basic code.
if you need to have an integer value in your end code format the value in your specific situation, Also the Slider component has a decimal attribute inherited from RangeRect, see if it's useful in you situation.
Thanks,

UI-DEN-5751-1 01 Feb 2021

RESOLVED.

UI-DEN-3605-4 14 Oct 2020

I have found a way to test this without using QThread. So, QThread has been removed

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

An extra line is needed here.

TESTSUITES-DEN-3724-1 14 Oct 2020

Done. It is linked to that review now. See above "Linked reviews: UI-DEN-3605-4"

UI-DEN-3605-4 30 Sep 2020

It's a very immediate value setting to sending value to the view.
Also sending these values before checking the dependencies to the other values seems redundant.
I suggest keeping the values and on confirm (or whatever the confirm button is) sending the final values to the view.
Please apply this for performance.

DG-DEN-6080-1 29 Dec 2020

Done

TESTSUITES-DEN-3724-1 15 Oct 2020

RESOLVED

UI-DEN-4964-1 15 Oct 2020

RESOLVED.

UI-DEN-4964-1 16 Oct 2020

RESOLVED.

HD-DEN-4640-1 19 Oct 2020

Done.

DG-DEN-5864-1 02 Dec 2020

Done

HD-DEN-5053-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5283-1 19 Oct 2020

Removed.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5736-1 02 Dec 2020

done

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5283-1 19 Oct 2020

These should be deleted. There should be 2 lines between each function. 1 line between each method in a class

DG-DEN-5864-1 02 Dec 2020

Can we fulfill this TODO now with the changes to the RO pump?
Suggest replace with setROPumpTargetFlowRate( FILL_TARGET_RO_FLOW_RATE, FILL_TARGET_RO_PRESSURE_PSI ).

DG-DEN-5855-1 03 Dec 2020

Done

UI-DEN-5736-1 03 Dec 2020

RESOLVED.

DG-DEN-5855-1 03 Dec 2020

Moved it to execDrainPumpMonitor function.

DG-DEN-5855-1 03 Dec 2020

Sorry I forgot to put the param name completely.

UI-DEN-5736-1 03 Dec 2020

RESOLVED.
As per our conversation today, these uncovered issues will be addressed as part of the squish migration.

DIALIN-DEN-3421-1 07 Dec 2020

I didn't want to assume values for these. Ultimately, user will need to set these to appropriate values before running the script.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5864-1 30 Nov 2020

This list does not match number of controllers in .c file.

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3421-1 07 Dec 2020

The state parameter needs to be added to the docstring

UI-DEN-5751-1 01 Feb 2021

RESOLVED.

UI-DEN-4598-1 09 Nov 2020

Later please change the class name to MTreatmentEndResponse (Treatment after M and End After Treatment).

DG-DEN-8030-1 13 Jun 2021

Done

HD-DEN-5053-1 15 Oct 2020

Done.

HD-DEN-5053-1 15 Oct 2020

Done.

HD-DEN-5053-1 15 Oct 2020

Done.

UI-DEN-4964-1 16 Oct 2020

RESOLVED.

DG-DEN-3421-1 19 Oct 2020

Done

UI-DEN-4964-1 29 Dec 2020

Done.