•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-4641-1 01 Dec 2020

Why is this #include in <> and not ""?

DG-DEN-3421-1 12 Aug 2020

I would call Reservoir/RSVR/R all the same as R1 and R2 everywhere.

DIALIN-DEN-6018-2 23 Dec 2020

Why are these modules commented out?

DG-DEN-3504-1 10 Nov 2020

Done.

DG-DEN-5963-1 12 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5283-1 19 Oct 2020

done.
thanks for the comment.

UI-DEN-5283-1 19 Oct 2020

Why is this named _private? Could there be a better name?

DG-DEN-6080-1 29 Dec 2020

Done

HD-DEN-7395-1 12 Apr 2021

Addressed.

DG-DEN-6080-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

Please comment the variables in the struct.

DIALIN-DEN-3421-1 03 Dec 2020

Sean Nash Could you please respond?

UI-DEN-5736-1 01 Dec 2020

Please get with SYS Engineering and SeanN of FW to get to the bottom of this. Once you got an answer, please remove comment.

HD-DEN-5381-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 29 Dec 2020

Done.

UI-DEN-4598-1 10 Nov 2020

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

UI-DEN-4964-1 29 Dec 2020

Done.

DG-DEN-3421-2-1 11 Nov 2020

Done

DIALIN-DEVELOP-BUG-FIXES-1 11 Nov 2020

Done

UI-DEN-5777-1 01 Feb 2021

cannot

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

DG-DEN-3421-2-1 12 Nov 2020

Done

DG-DEN-3504-1 10 Nov 2020

Add blank line between local declarations and code.

DG-DEN-3504-1 10 Nov 2020

Add space between local function declarations and code.

DG-DEN-3504-1 10 Nov 2020

Missing @param in function header.

DG-DEN-3421-2-1 10 Nov 2020

For modules that control or monitor h/w, I would like details of the h/w added to the module brief (e.g. mfg, p/n, some summary details from datasheet, ...).

DG-DEN-3421-2-1 10 Nov 2020

Why set a PWM duty cycle % with a max PWM delta. That doesn't make sense either. Should set to last calculated + max PWM delta.

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

HD-DEN-4641-1 01 Dec 2020

Done.

DG-DEN-6080-1 30 Dec 2020

Both inputs and outputs are currentDrainPumpRPM?

HD-DEN-4641-1 01 Dec 2020

Done.

HD-DEN-4641-1 01 Dec 2020

Yes. Fixed.

DG-DEN-3421-2-1 01 Dec 2020

Done

HD-DEN-5674-2 30 Dec 2020

With our alarm lamp LED(s), turning the green and red LEDs on will give us yellow.

DG-DEN-3421-2-1 01 Dec 2020

I removed this #define as it will not be used anymore.

DG-DEN-5855-1 03 Dec 2020

We do check inside that function and raise an alarm if needed. But for Dialin we check in the function too so if the RPM is out of range, it will return a FALSE rather than raising an alarm.

UI-DEN-6349-1 11 Jan 2021

Thanks, these links are helpful

DG-DEN-5855-1 08 Dec 2020

Done

DG-DEN-5846-1 04 Dec 2020

Moved the function to execFans function.

DG-DEN-5846-1 04 Dec 2020

Done

UI-DEN-6349-1 12 Jan 2021

This file is now deleted

DIALIN-DEN-3421-1 07 Dec 2020

RESOLVED.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DIAL-23-1 12 Jan 2021

This is an output that is generated from the alarm list inside common repo (output of the script gen_alarm_ids.sh).
This helps keeping the alarm id lists more up-to-date in DIALIN.

DG-DEN-5846-1 07 Dec 2020

Fixed the sentence.

UI-DEN-5830-2 12 Jan 2021

Can delete

DG-DEN-5855-1 08 Dec 2020

Changed the input to none.

DG-DEN-5846-1 09 Dec 2020

Done

DG-DEN-5873-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.