•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-2-1 23 Nov 2020

How variable these parameters are between thermistors (across machines)?

HD-DEN-4641-1 24 Nov 2020

Why double underscore between BUFFER and LEN?

DG-DEN-5873-1 30 Nov 2020

Blank line between HALCOGEN includes and normal includes. Alphabetize both #include sets.

DG-DEN-5873-1 07 Dec 2020

Done

HD-DEN-7395-1 12 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

UI-DEN-5283-1 20 Oct 2020

RESOLVED

HD-DEN-5053-1 20 Oct 2020

Space between 250 / TASK...

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-3421-1 26 Oct 2020

Set drainPumpDAC in set function - not here.

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5282-1 28 Oct 2020

Why removed?

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 10 Nov 2020

I've noted this and will make sure to resolve it later

DG-DEN-6081-1 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Done.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Done.

HD-DEN-5674-2 30 Dec 2020

there is (formal) instead of there's (informal)

DG-DEN-3504-1 10 Nov 2020

Done.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-3504-1 10 Nov 2020

Done.

DG-DEN-3421-2-1 13 Nov 2020

Align with the line above.

UI-DEN-4964-1 03 Jan 2021

Addressed.

UI-DEN-4691-1 10 Nov 2020

RESOLVED.

UI-DEN-4964-1 03 Jan 2021

Addressed.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Consider initializing these to something higher than anything possibly real so that it will never look lower than a real measurement.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 03 Jan 2021

Addressed.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Recommend splitting this condition into separate pump ID validation and target speed range check conditions. Then you won't have to determine reason for alarm in else below.

DG-DEN-3504-1 10 Nov 2020

Should you initialize pumpTargetSpeed[] elements here?

DG-DEN-3504-1 10 Nov 2020

Add decimal point to 2. Add more to comment to explain the 2 x 0.25 part of this definition.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Number of micro-steps per what?

DG-DEN-3421-2-1 13 Nov 2020

It should be an AND rather than OR if we would like to check both are healthy.

UI-DEN-4964-1 03 Jan 2021

RESOLVED

DG-DEN-3421-2-1 13 Nov 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Formalize sentence.

DG-DEN-3504-1 13 Nov 2020

It was acting as a function to turn off concentrate pump if HD commands DG exits fill mode, but has been removed due to reservoir module will handle this.

DG-DEN-3421-2-1 13 Nov 2020

Brought the function declarations back.

DG-DEN-5864-1 30 Nov 2020

Revert the change, other doxygen format is correct.

DG-DEN-5846-1 30 Nov 2020

This large comment should probably be moved into the function brief so SDD can benefit.

DG-DEN-5846-1 30 Nov 2020

This is a one-shot init function, so timing not critical, but I would still do this calculation once and assign to local float, then assign these fields from the local float.

DG-DEN-5846-1 30 Nov 2020

Should explain it's an enum or index for the temperature sensor we're getting temperature reading for.

DG-DEN-5846-1 30 Nov 2020

Missing param name.

DG-DEN-5846-1 30 Nov 2020

Done