•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4598-1 10 Nov 2020

RESOLVED

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 10 Nov 2020

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

HD-DEN-5674-2 30 Dec 2020

Do not transmit if not other nodes on CAN bus

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Add "Been" to function names (e.g. hasTargetFillVolumeBeenReached()).

DG-DEN-3504-1 10 Nov 2020

For modules that are controlling or monitoring h/w, add details of the h/w in the module brief (mfg, p/n, any summary details from data sheet, ...).

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 13 Nov 2020

Consider update the pin signal state inside setReactorEnableStatus() function. So there is no need to keep updating the pin signal state after each call to function setReactorEnableStatus().

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

do not (formal) instead of don't (informal)

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 12 Nov 2020

Measured speed is kept in an override array.
Added checking for measured speed vs. commanded speed.

DG-DEN-8030-1 15 Jun 2021

Should this be F64 as well?

DIALIN-DEVELOP-BUG-FIXES-1 17 Nov 2020

RESOLVED.

DIALIN-DEN-5674-2 06 Jan 2021

RESOLVED

DG-DEN-5864-1 07 Dec 2020

Done

DG-DEN-5846-1 30 Nov 2020

Yes, that is true. We never check for RPM being 0 after POST.

DG-DEN-5846-1 30 Nov 2020

I didn't have measured because there is not commanded as you mentioned. But changed the name.

DG-DEN-5846-1 30 Nov 2020

Could you please elaborate?

DG-DEN-3421-2-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Mispelled Result?

DG-DEN-5846-1 30 Nov 2020

Set result to pass before running the for loop. Remove failure count and set self test result to fail in place where we increase failure count.
We can get rid of this if else.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 30 Nov 2020

Persistent Alarm module now uses time interval rather than count. Change this to time period.

DG-DEN-5855-1 30 Nov 2020

This enum does not match the count or order of the controller table in the .c file.

DG-DEN-5864-1 07 Dec 2020

Done

DG-DEN-5846-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14170-1 07 Nov 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-3421-1 22 Oct 2020

Changed the location of the start command to ModeStandby.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 26 Oct 2020

Done

DG-DEN-5963-1 04 Jan 2021

Didn't Sunny say we need at least 25 PSI at inlet?

HD-DEN-4640-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5963-1 04 Jan 2021

This arrangement looks odd. Should be desired time / interval. You have double desired time / double interval. Why?

DG-DEN-3421-2-1 13 Nov 2020

Align comment.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 13 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

Your solution requires a code change to be made and the entire denali application to have to be rebuilt every time a treatment parameter needs to be adjusted by systems. This will not serve the needs of the system team. To fulfill their needs it was requested at the time to put the values in a file. You and I agreed at the time that the treatment parameter ranges should be read from a file. These two treatment parameter ranges are being read from QML which contradicts our agreed-upon decision to have them read from a file.

DG-DEN-3421-2-1 13 Nov 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 13 Nov 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

we have (formal) instead of we've (informal)

DG-DEN-3421-2-1 13 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5777-1 01 Feb 2021

fixed.

DG-DEN-5963-1 04 Jan 2021

Add else for s/w fault. Or maybe load cell driver or Reservoirs module should have a generic get weight function for a given reservoir.

DG-DEN-3504-1 13 Nov 2020

This was responsible for turn off concentrate pumps when HD commands DG to exit out of fill mode, but reservoir module has handled this.