•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7347-1 01 Apr 2021

I think memset is in string.h. Should you add a #include <string.h> at top of module?

UI-DEN-7044-1 29 Mar 2021

If you made sure your threading is fine please remove these debug which will fill up the log so fast.
Please remove the other ones as well if not needed.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-11250-1 16 Feb 2022

Removed the line "from dialin.dg.dialysate_generator import DG"

UI-DEN-7135-1 01 Apr 2021

When...VM, (comma after VM)...the application

UI-DEN-5751-1 01 Feb 2021

RESOLVED

HD-DEN-6402-1 01 Feb 2021

So if calibration is good but flow sensor is bad, we won't apply calibration? I think these two checks should be separated. Start test as passed. Then fail if either check is failed.

HD-DEN-6402-1 01 Feb 2021

Looks like you've merged prime and wet self-tests. Maybe mention wet self-tests in the comment.

DG-DEN-6200-1 14 Jan 2021

Updated logic flow to make variable name easier to understand and less confusing.

UI-DEN-7135-1 01 Apr 2021

...each instruction...

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

Fixed.

DIALIN-DEN-9480-1 11 Nov 2021

It is true we should be consistent. I added the NUM_OF_... at the end of the enum.

UI-DEN-6349-1 15 Jan 2021

I checked out to the branch and I don't see the usage of this class in any QML file.

DG-DEN-5980-1 23 Mar 2021

We have a very similar enum in valves.h. Why can't we use that enum?

UI-DEN-5830-2 15 Jan 2021

RESOLVED.

DG-DEN-5963-1 08 Apr 2021

Where did these go?

HD-DEN-5980-1 22 Feb 2021

Delete this function. Obsolete.

HD-DEN-5980-1 22 Feb 2021

Leave this as is and just don't define SKIP_POST build switch if you want your POST to run.

DG-DEN-6200-1 15 Jan 2021

Why and where were these persistent alarm moved to?

UI-DEN-6349-1 13 Jan 2021

I remember I mentioned somewhere in the code to use the QObject internal timer and also mentioned MainTimer as an example.
But I didn't mean to use the MainTimer.
Please look at the MainTimer as an example of how to use the QObject internal timer and use it instead of the MainTimer itself.

DIALIN-DEN-5980-1 24 Mar 2021

I thought I refactored it. The variable length is refactored to received_ms_length.

HD-DEN-5980-1 25 Mar 2021

This line has been updated. Please look at below.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

HD-DEN-5980-1 26 Mar 2021

Done.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 22 Feb 2021

Position may be ok. Check dependencies though.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 22 Feb 2021

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

HD-DEN-5980-1 29 Mar 2021

It will be addressed in the future stories.

DIALIN-DEN-7117-1 01 Apr 2021

RESOLVED

HD-DEN-7117-1 01 Apr 2021

I think it should be and. Because it is a "whichever is greater" condition. So if error is 6% but delta is less than 0.1 mL, I would not want to trigger the error because the volume is too small to alarm on a percentage basis. Likewise, if delta is > 0.1 mL but error is < 5%, no alarm.

DIALIN-DEN-5980-1 01 Apr 2021

RESOLVED

DG-DEN-5963-1 03 Apr 2021

This state has been removed.

UI-DEN-7044-1 31 Mar 2021

Done

DIALIN-DEN-5980-1 01 Apr 2021

This should remain unchanged

DIALIN-DEN-5980-1 01 Apr 2021

This should be received_msg_length

HD-DEN-7347-1 01 Apr 2021

Is this function necessary? Couldn't you just call the function above and look for FALSE return value?

HD-DEN-7117-1 01 Apr 2021

Replace 0x80 with constant and define it at beginning of *.c file.

HD-DEN-5980-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 03 Apr 2021

TRo is used as the coldest spot until V3.

DG-DEN-5963-1 03 Apr 2021

Done.

DG-DEN-5963-1 03 Apr 2021

This is the oneliner syntax, what do you mean by setting them explicitly?

DG-DEN-5963-1 03 Apr 2021

THd belongs to this group. TRo is temporarily used as THd.

DG-DEN-5963-1 03 Apr 2021

I moved the location of the comment.

DG-DEN-5963-1 03 Apr 2021

These enums are the possible status that can occur during the actual heat disinfect.

DG-DEN-5963-1 03 Apr 2021

The #defines are aligned.