•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

HD-DEN-7395-1 24 Mar 2021

Move both leak monitors to monitors section above.

HD-DEN-7117-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 23 Mar 2021

Update function description.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

It will be addressed in the future stories.

HD-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5777-1 01 Feb 2021

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

HD-DEN-7395-1 24 Mar 2021

Check should only be done if not doing self-test. If doing self-test, a different (opposite) check should be done (if blood not detected within TBD ms, fault).

UI-DEN-5751-1 01 Feb 2021

RESOLVED

UI-DEN-7135-1 01 Apr 2021

...that has...for each instruction-based...

UI-DEN-5751-1 01 Feb 2021

created a sub-task for this as DoubleSlider doesn't have this validation/active feature.
// TODO : Will be addressed in sub-task DEN-6686.

HD-DEN-7395-1 24 Mar 2021

Alarm if in patient connected mode/sub-mode, fault if not.

HD-DEN-6372-1 23 Feb 2021

Timeout is not in ms. Renamed constant.

HD-DEN-5980-1 22 Feb 2021

Delete this function. Obsolete.

UI-DEN-4860-BLE-1 14 Jan 2021

So we may need to be careful when we are adding the WiFi driver in here later.
RESOLVED.

HD-DEN-5980-1 22 Feb 2021

Just delete this case. Obsolete.

HD-DEN-7091-1 01 Mar 2021

This file is generated by halcogen and should not be modified.

DG-DEN-7568-1 14 Apr 2021

So this function looks a lot like the transition function in standby mode. So maybe standby mode could have a public function that resets all of the actuators and then the transition function in standby mode could call that function (and your modes could also call that function instead of this one).

HD-DEN-7091-1 22 Mar 2021

Combined air trap and bubble detectors into one used cartridge check.

DG-DEN-5963-1 15 Apr 2021

Done.

HD-DEN-5980-1 22 Mar 2021

Done

HD-DEN-5980-1 22 Mar 2021

I just need to run NVDataMgmt POST and nothing else. I added a build switch.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 22 Mar 2021

Done

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6200-1 15 Jan 2021

I think the flow rate out of range alarm should be handled by the RO pump driver.

UI-DEN-6349-1 14 Jan 2021

I've added it now, looks like it was accidently omitted

UI-DEN-5830-2 12 Jan 2021

Add TODO on commented out line or delete commented line. This way, we can always find it.

DG-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

I set them explicitly.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 13 Jan 2021

I checked out into the code and seems like the VBluetoothDeviceInfo class is not a view class although it has properties.
So, why it has V in the naming, and why it has property?
Views are only intended to be used in QML to interact with the C++ backend.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 23 Mar 2021

This part was used for testing only. I removed it. Do you mean the hardcoded calibration values?

DIALIN-DEN-5980-1 24 Mar 2021

RESOLVED

DG-DEN-5980-1 24 Mar 2021

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

UI-DEN-7035-1 24 Mar 2021

From my design meeting notes I have it written down that we will always be in pacific time as no other timezones will be supported. So, these lines just force the timezone to PST. I've moved this to setup.sh since it really only needs to be run once. Then later more work can be done to add support for timezone adjustment.

UI-DEN-7035-1 24 Mar 2021

Done

DIALIN-DEN-5980-1 17 Feb 2021

This function won't work now right? Instead of sending msg to DG, should update accel section of DG cal record dictionary and call external function to send whole cal record to DG. Should also call external function to read whole cal record from DG first and then need a get function to pull the accel section from DG cal record dictionary.

DIALIN-DEN-7117-1 24 Mar 2021

Moved to common and converted to enum.

HD-DEN-5980-1 25 Mar 2021

This line has been removed.

HD-DEN-5980-1 25 Mar 2021

This has been uncommented.

HD-DEN-7395-1 25 Mar 2021

Addressed.

HD-DEN-7395-1 25 Mar 2021

Addressed.

Note: I did a git pull on my hdfirmware branch (I should not have done that). To get my code working, I had to remove.

HD-DEN-7395-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 24 Mar 2021

Add TODO for all commented lines below.