•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-6349-1 08 Jan 2021

please move all the private member variables to the default private section of the class.

UI-DEN-5777-1 01 Feb 2021

"File cannot be opened for read (%1). Possible corrupted file system."

1. Rephrase and spell cannot as mentioned.
2. Add space between two sentences.
3. Add "." at end of 2nd sentence.

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

HD-DEN-6402-1 01 Feb 2021

Why do we need this start state? For modes, we have the transitionTo...() functions that get called automatically before starting a new mode. For sub-modes and their states, the general approach should be to handle transition logic at the same point the code changes the sub-mode/state. You can consider a separate transition state like this if there are a lot of states that could transition to this state or if the transition is very complex, but this one doesn't seem to fit either category.

DG-DEN-6200-1 15 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 01 Feb 2021

Dry-run?

HD-DEN-6200-1 15 Jan 2021

Done.

UI-DEN-7044-1 29 Mar 2021

Please Just make sure that the Alarm can show up and cover any dialog also.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

HD-DEN-6372-1 22 Feb 2021

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

DG-DEN-7091-1 01 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8030-1 15 Jun 2021

Not quite what I had in mind.
I meant that, regardless of whether sharing a connector, you would always "get" the new heat disinfect temperature.
Inside TempSensors, you would have the build switch. If using TRO connector for new sensor, fill THd from TRo temp sensor and fill TRo from TDi temp sensor (both TDi and TRo share TDi sensor). If THd has its own connector (DVT system?), then fill THd from THd sensor and TRo from TRo sensor as you would normally expect.

HD-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 13 Jan 2021

Please use macros for the connections, whenever possible.

HD-DEN-6078-1 18 Jan 2021

Need an alarm (fault) to be triggered as well - otherwise f/w will try to continue in whatever mode we're in.

HD-DEN-6200-1 18 Jan 2021

One msg for all DG commands? How will HD know which command is being responded to?

HD-DEN-6890-1 09 Mar 2021

Also mention return value in @return of header.

HD-DEN-7395-1 09 Apr 2021

Addressed.

HD-DEN-7091-1 22 Mar 2021

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement.
Removed the check for settle time in second displacement setup.

UI-DEN-7044-1 29 Mar 2021

Why Network being registered?

HD-DEN-7091-1 22 Mar 2021

Wrong valve state. Fixed.

DG-DEN-5963-1 22 Mar 2021

When is status unknown? And shouldn't there be a partially full status?

HD-DEN-7395-1 27 Mar 2021

Recommend using the functions from blood leak driver.

HD-DEN-5980-1 22 Feb 2021

Remove "_DIALYSIS" and it should compile. Do this throughout.

HD-DEN-5980-1 22 Feb 2021

Why are these commented out?

DG-DEN-5963-1 08 Apr 2021

Replace logic with a temp parameter (call it whatever you like) and then use that parameter in the function call. This will make the code a lot more legible.

DG-DEN-5963-1 08 Apr 2021

Remove "for" at end of @param sentence.

DG-DEN-5963-1 08 Apr 2021

Replace a with a more meaningful variable name.

HD-DEN-5980-1 25 Mar 2021

I added a build switch so the functions are un-commented.

HD-DEN-5980-1 25 Mar 2021

This function has been deleted.

HD-DEN-7395-1 25 Mar 2021

Addressed.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

HD-DEN-7395-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 27 Mar 2021

Done.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 28 Mar 2021

Done.

DG-DEN-5980-1 28 Mar 2021

Done.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 27 Mar 2021

if we skip POST, do we want to execute RTC POST test and other POST tests?

DG-DEN-5980-1 27 Mar 2021

Add break.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 29 Mar 2021

This function has been removed.

DIALIN-DEN-5980-1 29 Mar 2021

So I added a flag the prevents another request while a request to get data from firmware is in progress.

DIALIN-DEN-5980-1 01 Apr 2021

RESOLVED

DIALIN-DEN-5980-1 01 Apr 2021

RESOLVED