•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7395-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 23 Mar 2021

Are we getting load cell weight in other units somewhere else? If not, I would suggest defining the units in the function header and removing it from the name of the function.

HD-DEN-5980-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7044-1 01 Apr 2021

Moved this to onStart() and calling start() in main.cpp which emits a private signal didStart() that is connected to onStart as we discussed

DG-DEN-5980-1 28 Mar 2021

That is right. I added another build switch to only run POST on RTC and NVDataMgmt only.

DG-DEN-5980-1 28 Mar 2021

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 01 Apr 2021

I think this should be an and because of the "whichever is greater" part of the condition.

UI-DEN-7044-1 01 Apr 2021

Updated it to use the settings stack specifically when popping or pushing

DIALIN-DEN-5980-1 01 Apr 2021

Done.

UI-DEN-7044-1 01 Apr 2021

I agree it should be private. I've updated it to onAddNetwork and it is now private

DIALIN-DEN-5980-1 01 Apr 2021

RESOLVED

HD-DEN-7117-1 02 Apr 2021

Done.

HD-DEN-7117-1 29 Mar 2021

Should this be an or?

HD-DEN-7117-1 29 Mar 2021

Should this be an or?

HD-DEN-7117-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 24 Mar 2021

Add TODO.

HD-DEN-5980-1 24 Mar 2021

Add TODO to commented lines.

DG-DEN-5963-1 03 Apr 2021

Yes. In Disinfect R1 to R2 and Disinfect R2 to R1, the reservoirs might leak, or we might not be able to reach to 81C within the specified time.

UI-DEN-7135-1 05 Apr 2021

These are test files for now.
Later when we have a real file designed these will be replaced with some real names.

HD-DEN-7091-1 06 Apr 2021

Done. Updated syringe pump driver to match HD-DEN-7117-1.

DG-DEN-12931-1 03 Aug 2022

Done.

HD-DEN-6402-1 09 Feb 2021

Done.

HD-DEN-6402-1 04 Feb 2021

When we run blood pump in forward direction, we should see negative on arterial and positive on venous.
This limit here is to stop blood pump even if the time to run the blood has not been reached.

UI-DEN-4860-BLE-1 14 Jan 2021

We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files.
Since the SD card might be damaged and we still need to store settings.
Please change it to refer to the application location and name the folder as configuration or settings.

HD-DEN-6402-1 01 Feb 2021

Capitalize state

DG-DEN-6200-1 15 Jan 2021

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

DG-DEN-6402-1 11 Feb 2021

Do we finish comments with "." or not? Let us be consistent throughout.

HD-DEN-6200-1 15 Jan 2021

I understand that prime will likely finish its job before the reservoir fills, but what if it doesn't? If fill finishes first, this code will switch reservoirs before prime was done using it.

UI-DEN-4860-BLE-1 12 Jan 2021

This component is so general and not all the use cases need a back button.
Please remove it from here and move it somewhere more suitable.

DG-DEN-6200-1 15 Jan 2021

Where is alarmIsActive[] input in the code?

HD-DEN-6402-1 08 Feb 2021

Done.

DIALIN-DEN-5830-2 18 Jan 2021

There is a script repository in which we keep all the general/common scripts there and since it is not only Dialin related preferred to keep it there.
ssh://git@192.168.10.132:7999/ui/scripts.git

HD-DEN-6402-1 08 Feb 2021

Done.

UI-DEN-6349-1 18 Jan 2021

Done

HD-DEN-7347-1 07 Apr 2021

Not needed. Included in SystemCommMessages.h.

HD-DEN-7347-1 08 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 08 Feb 2021

This flag does not appear to be a "result". Rename to primeCompleted.

HD-DEN-6402-1 03 Feb 2021

Done. It is a tolerance on pressure difference after we return back to normal state from pressure self-tests.

UI-DEN-7044-1 08 Apr 2021

Addressed - ready for review

HD-DEN-6402-1 09 Feb 2021

Done.

DIALIN-DEN-6363-1 08 Feb 2021

I've updated to make this a parameter so the behavior is up to the API user. By default, I've set it to send a login request just once.

DIALIN-DEN-6363-1 09 Feb 2021

RESOLVED.

UI-DEN-7135-1 09 Apr 2021

Yes, it has to be on the same line to be the group.

HD-DEN-6372-1 11 Feb 2021

Do we need a #define 0.8?