•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6372-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 08 Feb 2021

Is this response persistent? Or does this function consume the response? Even if persistent, I suspect a new response will replace previous response and this makes me nervous. I think it would be safer to have a separate flag for each possible response so there is no race condition.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

Remove all extra "/" from all comments.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 01 Feb 2021

Add _ML_MIN to end to indicate units.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 01 Feb 2021

And if we fail self-tests? Where do we go? Are all failures a fault?

HD-DEN-6402-1 11 Feb 2021

TODO is at line 32.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

DG-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

DG-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

DG-DEN-6402-1 11 Feb 2021

Is this initial RO pump target flow rate or this is fixed? If initial, we should indicate as this will be set by controller to achieve desired flow rate.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

DG-DEN-6402-1 11 Feb 2021

Remove "to" from sentence.

HD-DEN-6402-1 11 Feb 2021

Add comment for this #define.

UI-DEN-4860-BLE-1 12 Jan 2021

Please Simply use the iArrow. why rotating two line to shape an arrow ?!

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

We can but not necessary - only necessary when using == operator.

DG-DEN-6200-1 15 Jan 2021

TODO?

DG-DEN-6200-1 15 Jan 2021

Do you think this function should be moved to PersistentAlarm.c?

HD-DEN-6402-1 11 Feb 2021

No, this is for system version <= P-BETA v0.5.

DD-LEAH-227-1 01 Oct 2024

done.

UI-DEN-7135-1 09 Apr 2021

done

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-5887-1 09 Feb 2021

User will request treatment end via the alarm system instead of having a dedicated button on the main treatment screen. So this function became obsolete.

HD-DEN-6402-1 08 Feb 2021

It will persist unless HD issues another command to DG.

HD-DEN-6402-1 09 Feb 2021

This will be done once we get to patient connection sub-mode. Added TODO.

UI-DEN-6349-1 15 Jan 2021

Noted

HD-DEN-6402-1 09 Feb 2021

Done.

HD-DEN-6200-1 15 Jan 2021

I think we want to be broadcasting priming progress (% complete or maybe est. time (in secs) countdown) during prime (really prime+wet self-tests) so UI can show progress. Peter may have already defined a msg for this. Consider what else may need to be broadcast during prime for Dialin purposes.

DG-DEN-6200-1 18 Jan 2021

Added command id to command response.

HD-DEN-6200-1 18 Jan 2021

Are these for HD to DG commands? Clarify in comment, name.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

UI-DEN-7135-1 12 Apr 2021

RESOLVED

UI-DEN-7135-1 12 Apr 2021

RESOLVED

DG-DEN-6402-1 11 Feb 2021

Doxygen needs /// (previous line) or ///< (same line) or it won't pick up the comment.

HD-DEN-7395-1 12 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 01 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6402-1 11 Feb 2021

Why the RPM has been lowered?

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.