•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 01 Feb 2021

Can this wait for door close be a state within the self-test no cartridge sub-mode? Also need to wait for user to open the door at the end of self-test no cartridge sub-mode or beginning of cartridge install sub-mode and then close the door again at end of cartridge install sub-mode. I see that some of these sub-modes don't have states, but probably should or will eventually. The 3 self-test sub-modes can have their own state machines in SelfTests.c. I think Recirc and Cartridge Install sub-modes may need their own .c files (PreTreatmentRecirc.c and DisposableInstall.c?) with state machines of their own as well.

HD-DEN-6402-1 01 Feb 2021

Is this a maximum? Also, add _MMHG to end to indicate units of pressure.

HD-DEN-6402-1 01 Feb 2021

Is there no upper limit for arterial or lower limit for venous pressure?

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

DG-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

DG-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

Remove all extra "/" from all comments.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

So for system versions >= P-BETA v0.5, bloodFlowCalGain equals -1.0f? And why is the blood flow sensor installed forward on v0.4.5 and backward on all upward system versions?

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-5887-1 09 Feb 2021

Why was this removed? No more end treatment requested by user option?

HD-DEN-7091-1 22 Mar 2021

Added specific fault for each check.

HD-DEN-5980-1 22 Mar 2021

Yes it is part of fwcommon. To review fwcommon, please review DG-DEN-5980 code review.

HD-DEN-5980-1 22 Mar 2021

Done

DG-DEN-5980-1 23 Mar 2021

Are these string fields null-terminated? If so, we need an extra character for the null terminator.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

DG-DEN-5980-1 23 Mar 2021

Same comment as for mfg location.

DG-DEN-12931-1 03 Aug 2022

Done.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

UI-DEN-7044-1 07 Apr 2021

RESOLVED

HD-DEN-9906-1 15 Nov 2021

This should an F64.

DG-DEN-9906-1 15 Nov 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5830-2 12 Jan 2021

Where was this moved to? Or was it deleted?

HD-DEN-11098-1 19 Nov 2021

Done

DIALIN-DIAL-23-1 15 Jan 2021

RESOLVED.

HD-DEN-6402-1 01 Feb 2021

Fair point.

HD-DEN-6402-1 03 Feb 2021

Done.

HD-DEN-6200-1 15 Jan 2021

Changed drain volume to 0.

HD-DEN-6078-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

DG-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 15 Jan 2021

Add extra line.

HD-DEN-6200-1 15 Jan 2021

Add extra line.

HD-DEN-6402-1 08 Feb 2021

Done.

UI-DEN-6349-1 18 Jan 2021

Done

UI-DEN-6349-1 18 Jan 2021

Done

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.