•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-6200-1 15 Jan 2021

Added priming time countdown and priming current state.

HD-DEN-6078-1 18 Jan 2021

Done

HD-DEN-6402-1 03 Feb 2021

Reworded.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

HD-DEN-6402-1 03 Feb 2021

Done. Also moved the function to FPGA module.

HD-DEN-11098-1 18 Nov 2021

Make it clearer that this is for prime dialyzer state.

UI-DEN-4860-BLE-1 18 Jan 2021

RESOLVED

DG-DEN-6402-1 11 Feb 2021

Do we need any persistent alarm after a couple of trials? How many times are you planning to go back and forth?

DD-LEAH-225-1 16 Oct 2024

Do we need a calculated target temp?

UI-DEN-5830-2 18 Jan 2021

RESOLVED

HD-DEN-6402-1 11 Feb 2021

Next cmdSetDGActiveReservoir will put the valves back in a normal state.

DD-LEAH-225-1 16 Oct 2024

Is this TODO done in line below?

UI-DEN-4860-BLE-1 18 Jan 2021

RESOLVED

HD-DEN-6200-1 18 Jan 2021

The message has a command id field.

HD-DEN-6402-1 01 Feb 2021

What is this state? Where did it get set? Why aren't we going back to recirc state?

HD-DEN-6200-1 18 Jan 2021

Added clarification to comment and name.

UI-DEN-4860-BLE-1 18 Jan 2021

When we add the correct object dictionary in the names.py then sys/v&v/... can use it and don't need the object name anymore to do so.
Not 100% agree.
Also, we need to have a consistent naming for the currently existing objectName in the code, I'll later provide a standard.

RESOLVED

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5638-1 26 Jan 2021

If there is a bug in SquishQt please report to Froglogic and give feedback and please don't try to fix it by yourself.
In case they fix the bug (if there is a bug) and they fix it, and the fix is not compatible with your fix, then we have self-generated bugs.
Please remove these and let Froglogic know you found a bug and let them help us.

DG-DEN-6200-1 18 Jan 2021

If we are using a single message to respond to multiple commands, should we include a parameter indicating which command we are responding to?

DG-DEN-6200-1 20 Jan 2021

Maybe new reason like dialysate temperature not set?

DIALIN-DEN-6078-1 20 Jan 2021

RESOLVED.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

DIALIN-DEN-5638-1 26 Jan 2021

RESOLVED

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

Remove all extra "/" from all comments.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6890-1 10 Mar 2021

Removed.

DG-DEN-6890-1 10 Mar 2021

Removed.

HD-DEN-6890-1 11 Mar 2021

Addressed.

HD-DEN-6890-1 11 Mar 2021

It is recoverable. As soon as the fluid leak is cleared, this alarm will self-remove. This is a simple ON/OFF implementation because we have 0 tolerance for leaks.

DIALIN-DEN-6890-1 11 Mar 2021

Replaced with state.

HD-DEN-6890-1 09 Mar 2021

I don't think you need ModeTreatmentParams.h or OperationModes.h.

DG-DEN-6890-1 11 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6890-1 10 Mar 2021

Is this alarm recoverable? If yes, should we clear this alarm once no fluid leak is detected?

DIALIN-DEN-6890-1 11 Mar 2021

What is the variable upper used for?

DG-DEN-7091-1 13 Mar 2021

Ok, yes, I see that now. But I still don't see any check for dialysate temperature (after heating).

HD-DEN-7395-1 09 Apr 2021

Addressed.

HD-DEN-12224-16 24 May 2022

This function is still available and reverts back to default. It does not alarm though.

DIALIN-DEN-6078-1 20 Jan 2021

Done

HD-DEN-6200-1 20 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 18 Jan 2021

Pretreatment mode does not have data needed to be broadcast.
We might have more data once the mode is more mature.

UI-DEN-4860-BLE-1 18 Jan 2021

It's not the components themselves that do what you want it's how you call and manage it and having another component was unnecessary.
RESOLVED regardless.