Print statements have been replaced with self.logger calls in dialin to prevent flooding users consoles. So, it'd be best to either remove this or use self.logger.debug(...) instead
Before switching to newly filled reservoir, we want to take a baseline weight (before starting UF with it). So we are initializing the starting and final weights for the reservoir here. As UF progresses on this reservoir after we switch to it, the final weight will gradually increase and the delta between the two is how much UF we've taken using this reservoir.
There is a DG monitor function near top of this module. I recommend calling it from there. TaskGeneral should only be calling very high level functions.
1 - Since the name of the variable is not a major issue, I have noted your comment and will update the name to hd_simulator in a future revision. 2 - It does, it was added in a future revision. Please keep in mind this code review is 8 weeks old.
It would be great if we could make it optional. For the testing, it is very useful. I'll remove it but later, would like to have it as an option that can be set available manually.
The way it was used is in SquishQt examples, but I can't find any example that SquishQt is being used the way you used it. Please change it to the recommended ways in SquishQt examples.
Nothing has changed about the usage of the SquishQt API, other than the fact that the dictionary passed to waitForObjectExists previously wasn't really testing anything. Removing utils.dict_update it will break the test case.
I believe we discussed enough. And it was discussed verbally before to not to do it.
Nothing has changed about the usage of the SquishQt API. We pass a dictionary to waitForObjectExists prior to this change and after. Removing it will break the test case.
If nothing has changed so why your test would break. Please change it to the recommended ways in SquishQt examples.
You are running release
CR4.8.14
FE4.8.14
(20240111091859 2024-01-11 09:20),
please report your release number when reporting bugs.
