•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

Probably should be fabs() here. and change 1 to 1.0.

HD-DEN-7091-1 22 Mar 2021

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 24 Mar 2021

RESOLVED

HD-DEN-5980-1 24 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7035-1 24 Mar 2021
  • QStringLiteral should be used for a constant string that we know is not going to change so those will be created at compile time and not every time.
    Here seem all the options have to run and build at runtime.
  • Why used QLatin1Char instead of only "0"?
    This is a constant leading zero.
UI-DEN-7035-1 24 Mar 2021

Sure, I've updated it to use the date command.

UI-DEN-7035-1 24 Mar 2021

RESOLVED

DIALIN-DEN-5980-1 17 Feb 2021

Consider renaming all of the NV record modules/classes with record_ or nv_record_ prefix or maybe putting them in a sub-folder of dg so they are easily identified for their general purpose.

HD-DEN-7117-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 22 Mar 2021

Either add TODO or delete commented line.

HD-DEN-5980-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 28 Mar 2021

I changed the location this function to nv_ops_utils.py and I changed it use the calcsize method.

DG-DEN-5980-1 22 Feb 2021

You can remove the else - no longer needed.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 23 Mar 2021

is getCalibrationData function still existed? If not, need to remove it.

UI-DEN-5751-1 29 Jan 2021

How will this notification bar look if an alarm is raised but minimized? Would there be two notification bars visible?

UI-DEN-7044-1 29 Mar 2021

This one might be on_ not do_. and should be private!
A little confusing that if the signal comes from the interface how come the doAdd.... is public access?
What happens if it has been called on the qml side.
Could you please explain?

HD-DEN-13834-1 14 Oct 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 11 Jan 2021

Thanks, only a Numeric keyboard in this case.
Please also take a look at the KDAB training about the QtQuick keyboard handling, in https://www.youtube.com/watch?v=ilCekEOpNYM @ 5:40 using the Keys API to be able to navigate on 'enter' pressed.
that might be helpful.
I think it should be "enterPressed", "returnPressed", or both.

Please also take a look at the UX desing in the link : https://app.zeplin.io/project/5db0c175acfeac55e3cb879e/screen/5dbc8461bab7462c152cb34e

DIALIN-DEN-5751-1 29 Jan 2021

Should replace this hard-coded number with the exact number of alarms from len(dict).

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5751-1 01 Feb 2021

RESOLVED.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 08 Apr 2021

Addressed.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6631-1 15 Feb 2021

Removed.

DG-DEN-5963-1 14 Mar 2021

If we don't need this check anymore, just delete it.

DG-DEN-5963-1 08 Apr 2021

Spell out P in variable name (or use "Press" at least).

UI-DEN-6631-1 16 Feb 2021

it is a kind of hierarchy commenting that the //// is the title and the rest beneath that are like 1.1 and 1.2 so it helps to organize better.

UI-DEN-6631-1 16 Feb 2021

RESOLVED.

HD-DEN-6372-1 16 Feb 2021

Mismatch function name.

HD-DEN-6372-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6890-1 11 Mar 2021

I think you should call clearAlarmCondition() when you sense DRY state.

HD-DEN-6890-1 11 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-6890-1 11 Mar 2021

Addressed.

DIALIN-DEN-6890-1 11 Mar 2021

RESOLVED

DIALIN-DEN-6890-1 11 Mar 2021

RESOLVED.

HD-DEN-5980-1 22 Mar 2021

The calibration data is validated in NVDataMgmt driver.

HD-DEN-7117-1 19 Mar 2021

Done.

HD-DEN-7117-1 17 Mar 2021

Need doxygen description for new functions.

HD-DEN-7091-1 14 Mar 2021

Where is this used? Does it need to be public?

HD-DEN-7091-1 14 Mar 2021

Does HD have to follow these next 3 states of DG? Or could it just wait for DG to get to the dialysate productions state?

HD-DEN-7091-1 22 Mar 2021

Moved handle to pre-treatment mode. Go to standby mode when sample water test failed.

HD-DEN-7091-1 22 Mar 2021

RESOLVED in CODE WALKTHROUGH.