•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7091-1 22 Mar 2021

Remove blank lin.

HD-DEN-7091-1 22 Mar 2021

The valves were not correct. It should be back to the previous state when the BP is off.
The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP.
Added 2 seconds time out for pressure to be normalized.

HD-DEN-7091-1 22 Mar 2021

This test is more about the cartridge should be dry.
Sensors' faults should be part of POST or no cartridge self-tests.

HD-DEN-7091-1 22 Mar 2021

Fixed.

HD-DEN-7091-1 22 Mar 2021

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

HD-DEN-7091-1 22 Mar 2021

Fixed. Now the BP pump should be off when the test is done.

HD-DEN-7091-1 22 Mar 2021

Straw door needs to be open for concentrate jugs' connection. Other than that, I am not aware of any flow path that requires closed door.
Added TODO.

HD-DEN-5980-1 22 Mar 2021

Done

HD-DEN-5980-1 22 Mar 2021

Done

HD-DEN-5980-1 22 Feb 2021

Why is this commented out?

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

Is use of fabs() here appropriate? Do we really not care which pressure is larger? It looks like previous readings are with VBA/VBV closed and BP off while current readings are with BP on and valves open.

DG-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 23 Mar 2021

I removed the function.

DIALIN-DEN-5980-1 23 Mar 2021

Done.

DIALIN-DEN-5980-1 23 Mar 2021

It will no longer work. I removed the function.

DIALIN-DEN-5980-1 23 Mar 2021

They are added to the publish decorator.

HD-DEN-7117-1 23 Mar 2021

What does the V stand for in the name of this function? Can we be more explicit? If voltage, then "Volt".

UI-DEN-5751-1 29 Jan 2021

Should we consider here the case where payload is not empty but has garbage values in it?

UI-DEN-5751-1 29 Jan 2021

If FW responds back saying either arterial or venous pressure limit ranges are invalid, the user corrects them, and then we proceed, without doing anything upon validation success the pressure limits would still show up as invalid the next time the user enters the create treatment screen.

DIALIN-DEN-11250-1 16 Feb 2022

RESOLVED.

DG-DEN-8030-1 15 Jun 2021

Done.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5751-1 01 Feb 2021

Please refer to the general comment I put,
These codes are not maintained by UI.


The only files that were involved in these changesets are:

dialin/ui/hd_simulator.py
dialin/common/msg_defs.py
dialin/squish/denaliMessages.py
And all the other files are merged from master and other branches which were merged into master.

DG-DEN-8030-1 15 Jun 2021

Done.

DG-DEN-8030-1 15 Jun 2021

Remove dead code.

UI-DEN-6631-1 16 Feb 2021

RESOLVED.

UI-DEN-7135-1 09 Apr 2021

It only returns 0 for now.
Later I have the plan to improve the parser and will use the return value for the error handling.

UI-DEN-6631-1 16 Feb 2021

RESOLVED.

DIALIN-DEN-6631-1 16 Feb 2021

RESOLVED.

UI-DEN-7135-1 10 Apr 2021

RESOLVED.

HD-DEN-6372-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7135-1 01 Apr 2021

, the application

DG-DEN-5963-1 14 Mar 2021

Why is this banner deleted?

HD-DEN-5887-1 19 Feb 2021

Part of tuning of UF control. Load cells are so noisy, control interval seemed too fast at 1 Hz.

DG-DEN-5963-1 14 Mar 2021

Why commented out?

HD-DEN-6890-1 11 Mar 2021

Addressed.

DIALIN-DEN-6890-1 11 Mar 2021

The return from struct.unpack is a tuple. Need to add [0] add end of state to get the first index item.

DG-DEN-6890-1 12 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 19 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 14 Mar 2021

First condition should be in parenthesis too.

HD-DEN-7091-1 14 Mar 2021

From where is this function called?

DG-DEN-7091-1 13 Mar 2021

Don't we need to check other things here as well? Inlet temp and conductivity, reject ratio, and dialysate temperature.

DG-DEN-5980-1 21 Mar 2021

It was commented out for testing. I un-commented it.

HD-DEN-7091-1 22 Mar 2021

When the sample water result entered by the user, HD will command DG to end water sampling mode and go back to standby idle state.

HD-DEN-7091-1 22 Mar 2021

Moved handlers to pre-treatment mode.

HD-DEN-7091-1 22 Mar 2021

Removed. It seems nothing much we can do. The door switch is simple and just a GPIO read from FPGA.