•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-6402-1 15 Feb 2021

Should not there be two IDs we are passing in? i.e., are we taking both actions on the same reservoir?

UI-DEN-6349-1 01 Feb 2021

RESOLVED

UI-DEN-6349-1 01 Feb 2021

RESOLVED

HD-DEN-7347-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5751-1 01 Feb 2021

Please refer to the general comment I put,
These codes are not maintained by UI.


The only files that were involved in these changesets are:

dialin/ui/hd_simulator.py
dialin/common/msg_defs.py
dialin/squish/denaliMessages.py
And all the other files are merged from master and other branches which were merged into master.

HD-DEN-7117-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5751-1 01 Feb 2021

Please refer to the general comment I put,
These codes are not maintained by UI.


The only files that were involved in these changesets are:

dialin/ui/hd_simulator.py
dialin/common/msg_defs.py
dialin/squish/denaliMessages.py
And all the other files are merged from master and other branches which were merged into master.

DIALIN-DEN-5751-1 29 Jan 2021

Remove extra lines.

DIALIN-DEN-5751-1 01 Feb 2021

RESOLVED.

DIALIN-DEN-5751-1 29 Jan 2021

Delete all commented code lines below or add TODO next to each section.

DIALIN-DEN-5751-1 01 Feb 2021

RESOLVED.

UI-DEN-5751-1 01 Feb 2021

Sure, but that test is not here it is the checkCRC() function test.

UI-DEN-5751-1 01 Feb 2021

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   fromByteArray
     * \details converts the values from Byte Arrays to the Model data.
     * \param   vByteArray - the byte array input
     * \param   vIndex     - current index of each data section in byte array
     * \return  true on successful conversion
     */
    virtual bool         fromByteArray(const QByteArray   &vByteArray  , int *vIndex = nullptr)       = 0;
UI-DEN-5751-1 29 Jan 2021

It seems like some variables are being defined in QML while others are in cpp.
I've seen this happen with TreatmentCreate. What's the plan for where PRS default variables should be defined?

UI-DEN-7044-1 29 Mar 2021

Please take a closer look at the code.
At this moment you are still in the main thread and not in the Wifi Thread.

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

RESOLVED

UI-DEN-7044-1 07 Apr 2021

RESOLVED

UI-DEN-6349-1 01 Feb 2021

RESOLVED

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5751-1 01 Feb 2021

RESOLVED.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-11250-1 16 Feb 2022

RESOLVED.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 14 Mar 2021

If we're not doing all of this commented out monitoring, just delete it.

UI-DEN-6631-1 15 Feb 2021

fixed.

DG-DEN-5963-1 08 Apr 2021

Why using structs instead of enums?

DG-DEN-8030-1 15 Jun 2021

Yes, please remove. HD should set the target temp. I assume this was for dialysate heating tests.

HD-DEN-6372-1 16 Feb 2021

All alarm user actions are blocked in this sub-mode. Alarm stop signal flag is covered in this reset function.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6631-1 16 Feb 2021

Thanks for catching that,
Fixed.

HD-DEN-7091-1 15 Mar 2021

Since the UI follows HD states and not DG, HD has to follow these next 3 states of DG. This allows UI to tick off the checklist.

DG-DEN-6402-1 17 Feb 2021

This should be part of Non-Volatile Data Management code review.
Dara Navaei has added them to the alarm table.

HD-DEN-6372-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6890-1 10 Mar 2021

Why is this called fpgaGPIO? Why not leakDetector or something that is more representative of your driver?

DIALIN-DEN-6890-1 11 Mar 2021

RESOLVED

DIALIN-DEN-6890-1 11 Mar 2021

Should use MsgFieldPositions in common instead

DIALIN-DEN-6890-1 11 Mar 2021

Addressed.

DIALIN-DEN-6890-1 11 Mar 2021

Why is fluid_leak module being compared to a state?

HD-DEN-7091-1 14 Mar 2021

Does this flag indicate install requested or install confirmed?

DG-DEN-7091-1 19 Mar 2021

Let's update to v0.5.0.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 21 Mar 2021

To be able to run them on a simple board on my desk. I made a build switch for this. I used one of the older build switches instead of commenting out.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

Yes, I think so. The blood leak self test once set, the blood leak detector status will be high right away.

DG-DEN-7091-1 22 Mar 2021

Changed rate to 4 Hz.

DG-DEN-7091-1 22 Mar 2021

Do we need to know if concentrates door is closed before turning on pumps?

HD-DEN-5980-1 21 Mar 2021

Remove this typedef. It is defined in common repo.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.