The compiler generates extra code when we pack structures so I'd prefer not to unless needed. Generally, we only need packing if structure contains 8 or 16 bit data fields and we want to serialize the structure (i.e. for transmission).
What do you have in mind for door switch self-test? I would think that if we are confirming door close/open at various states, that might be good enough. Not sure what else we can do.
This function should have many parameters for all the dg calibration data. That way, you can remove the hardcoded numbers This function should be split up into multiple functions each with a single responsibility. This will improve readability and maintainability.
This is related to two different AUT configuration in SquishQt, 1 - while running with build scripts locally to make sure for the last time we have everything covered and that script builds the app as "denaliSquish" on local and on the server as well. 2 - the other is when we are at the very first stage of the testing and coverage and building back and forth to test and cover. that one used the QtCreator built "denali". To make it easy to work with these two configurations I made the name of the AUT as a variable so we can switch between quickly. The last moment on pushing on the master has to have "denaliSquish".
Why is this check commented out? Even if our RPM conversion is not great, we still need to be able to distinguish between off and on. Set a threshold and keep this check.
Because the fluid leak detector is packaged as part of a 16-bit (LSB + MSB) representing the GPIOs of the FPGA. This is to save space. I use a bitmask to extract that one bit I need which is representative of the fluid leak detector state (dry/1 vs. wet/0).
This init is called from main at startup. This seems to work, but I'd prefer to select initial active reservoir and set reservoir valves accordingly after POST - maybe in transition to standby mode. This way, if POST does something to the valves to test, we will set them afterward. Also gives valve driver and FPGA interface a chance to get started before we start giving actuator commands.
