•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-7091-1 13 Mar 2021

The return of this function includes a call to isWaterQualityGood(), which checks for inlet temp and conductivity, reject ratio, and temperature.
For the dialysate temperature, it will be done once I work on dialysate generation again and remove TODO.

DG-DEN-6402-1 17 Feb 2021

These have been uncommented.

HD-DEN-6372-1 16 Feb 2021

Need to review doxygen style in this file.

HD-DEN-6402-1 17 Feb 2021

These new alarms have been added to the alarm table.

HD-DEN-6372-1 17 Feb 2021

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

HD-DEN-6890-1 11 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 22 Mar 2021

Are you sure you want this run here after modes?

HD-DEN-7117-1 19 Mar 2021

Done.

HD-DEN-7091-1 22 Mar 2021

Should set settleStartTime here.

DIALIN-DEN-5980-1 23 Mar 2021

I removed the function.

DG-DEN-7091-1 22 Mar 2021

Checked with Nick. The DG does not expose motors to the user.
The straw door switch should be open in Fill Mode to allow access to straw connection.
The straw door switch should be closed in modes such as (heat disinfection, chem disinfection) to prevent user from exposure to hot water or chemical.

Added TODO.

HD-DEN-5980-1 21 Mar 2021

Comment's first letter needs to be capitalized.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 23 Mar 2021

Done.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 23 Mar 2021

I split the function.

HD-DEN-5980-1 24 Mar 2021

Add TODO.

DG-DEN-5980-1 24 Mar 2021

Done.

DG-DEN-5980-1 24 Mar 2021

I updated the comment.

DG-DEN-5980-1 24 Mar 2021

Done.

DG-DEN-5980-1 24 Mar 2021

Done.

DG-DEN-5980-1 24 Mar 2021

Changed them to NVDataMgmt NVDataMgmt.

DG-DEN-5980-1 21 Mar 2021

Done.

UI-DEN-7035-1 24 Mar 2021

RESOLVED

DIALIN-DEN-5980-1 17 Feb 2021

I think this should be moved to either CAN.py (in protocols folder) or in your new utils.py.

DIALIN-DEN-5980-1 17 Feb 2021

Clarify in seconds.

DIALIN-DEN-5980-1 17 Feb 2021

Clarify in seconds.

DG-DEN-5980-1 23 Mar 2021

Add () between each condition.

UI-DEN-7135-1 06 Apr 2021

Why Latin1 and not Latin? Are there two or more Latins?

UI-DEN-7044-1 24 Mar 2021

Are these the only measurable levels?

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5751-1 01 Feb 2021

RESOLVED.

UI-DEN-7135-1 05 Apr 2021

This image filename could be more descriptive. Will it have to be renamed if the order is changed?

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

RESOLVED

DG-DEN-5980-1 24 Mar 2021

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for that.

UI-DEN-5751-1 01 Feb 2021

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   parameters
     * \return  current data values of the models.
     */
    virtual QVariantList parameters   (                                                       ) const = 0;
HD-DEN-11980-1 16 Feb 2022

Fixed. Thanks!

DIALIN-DEN-6372-1 16 Feb 2021

Done.

UI-DEN-6631-1 15 Feb 2021

it is as formal (instead of it's as informal)

HD-DEN-6372-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 08 Apr 2021

One is for the Blood Leak Detector status (blood leaked or blood not leaked), and the other one is for the Blood Leak Detector state of its state machine. This is just in case we wanted to have independent control over these time constants.

HD-DEN-6372-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6372-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6402-1 17 Feb 2021

Need to add these to end of alarm table below.

HD-DEN-6402-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 10 Apr 2021

Addressed.

HD-DEN-6890-1 11 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7091-1 13 Mar 2021

Fixed.

DG-DEN-5963-1 14 Mar 2021

Why is all of this commented out? Just build switch the checks that aren't working and leave everything else alone.