Comment Search

getCurrentOperationMode() returns the current operation mode (standby, pre-treatment, treatment, post-treatment, etc.), not the sub-mode.

Why is UF off state goes back to UF running state right away? Should we remove this state then?

To be able to run it on a board with not hardware. I used one of the older build switched instead.

Why is bad sample result handled here and good sample result handled in pre-treatment mode?

This function is a duplicate. Any reason not to update cmd_send_dg_serial without breaking backwards compatibility?

Done.

This test is more about the cartridge should be dry.
Sensors' faults should be part of POST or no cartridge self-tests.

Pressure should be float. Add .0 to end of value.

While they are not mission critical, let's make an effort to keep these test functions clean by removing unused code.

Done

RESOLVED

We talked about a settingcontroller to be implemented later.
RESOLVED

Done.

Add TODO.

They are both in Water Cancellation Path state. They are separate because hot cancellation requires mix drain.

Recommend adding TRUE to the comparison and parenthesis around each condition.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Do both #ifndef need to be satisfied for this portion of the code to execute? Where (at what time) are these two parameters set?

RESOLVED in CODE WALKTHROUGH.

Remove commented out lines or add TODO on top of section.

What is the purpose of this? If there is a problem, shouldn't there be an alarm/fault? Seems like current mode may not be aware that the drain pump has been stopped here.

Replace with "Cannot" (no use of informal language in code comments)

Made it optional and disabled by default and only in Simulator is enabled.

Done.