•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7117-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7135-1 12 Apr 2021

RESOLVED

UI-DEN-11980-1 16 Feb 2022

remove this comment since it was there to separate the two models.

UI-DEN-7135-1 12 Apr 2021

RESOLVED

UI-DEN-7135-1 12 Apr 2021

RESOLVED

UI-DEN-7135-1 05 Apr 2021

If '=' is the last character or first character in the line this won't work

UI-DEN-7135-1 05 Apr 2021

Will '[' and ']' always be on the same line?

HD-DEN-7091-1 15 Mar 2021

It is called from task general.

DG-DEN-7091-1 13 Mar 2021

I think there are now 7 incoming CAN msg buffers (8 if counting the 1 serial port buffer).

DG-DEN-5963-1 22 Mar 2021

This looks tight. Will we pass? Do we need a bigger filter for temp sensors?

DG-DEN-7091-1 19 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 14 Mar 2021

Why commented out here? If you don't want this disabled, comment the build switch out in DGCommon.h.

DG-DEN-5963-1 14 Mar 2021

Why banner deleted?

HD-DEN-7091-1 22 Mar 2021

Done.

HD-DEN-7091-1 22 Mar 2021

How will DG standby get back to idle state from flush idle state? Where does that happen?

DG-DEN-5963-1 03 Apr 2021

I added the function to reset the actuators.

HD-DEN-7091-1 22 Mar 2021

Fixed.

HD-DEN-7091-1 22 Mar 2021

Should we have a specific fault for each no cartridge check instead of a single fault for all checks?
If we just have one fault, we are limited in what we can provide for data - you are giving the state that failure occurred.
If we had specific faults, we could provide more details (e.g. if board temp check fails, we could provide the measured board temp with fault).

HD-DEN-7091-1 22 Mar 2021

Can DG check if DG door closed? If so, should we confirm that the door is closed?

UI-DEN-7035-1 22 Mar 2021

No Msg Box?

UI-DEN-7035-1 24 Mar 2021

Good Point.
Isn't the BLE case apply everywhere?
I was thinking why we even want to hide the keyboard while users can hide it by the keyboard button on the keyboard.
We may give it more thoughts.
RESOLVED

HD-DEN-5980-1 22 Feb 2021

Consider creating a structure for the 3 U32s to reduce memcpys.

HD-DEN-7117-1 02 Apr 2021

Done.

HD-DEN-7395-1 02 Apr 2021

Yes. It should be removed or refactored once the actual blood leak self-test functionality is implemented.

HD-DEN-7117-1 02 Apr 2021

I am referring to the comment.

HD-DEN-7117-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 06 Apr 2021

Done.

DG-DEN-5980-1 06 Apr 2021

Yes, they are going to be used in mode flush and chemical disinfect as well as heat disinfect.

HD-DEN-7117-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 05 Apr 2021

This seems to be an incorrect message ID.

HD-DEN-7117-1 01 Apr 2021

Use 5 instead of five (easier to track and compare).

HD-DEN-7117-1 06 Apr 2021

Comments start with capital letter.

HD-DEN-7117-1 06 Apr 2021

It would be helpful to say which syringe pump controller signal is being passed via all these channels instead of just a channel number.

HD-DEN-7117-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 06 Apr 2021

Any reason why these are in common header? Does anybody else use them? If not, make private to HeatDisinfect module.

DG-DEN-5980-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7117-1 06 Apr 2021

RESOLVED.

HD-DEN-11114-1 02 Dec 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11980-1 16 Feb 2022

Fixed. Thanks!

HD-DEN-7395-1 08 Apr 2021

[~qnguyen] Please address.

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-11980-1 16 Feb 2022

Fixed. Thanks!

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 14 Apr 2021

This section has been uncommented.

DG-DEN-8030-1 16 Jun 2021

Should this value be higher? The user could be using wrong concentrate jug if it is too low?

HD-DEN-7395-1 08 Apr 2021

But they could be packaged together into once blood leak data broadcast message.

HD-DEN-7395-1 08 Apr 2021

Recommend adding #defines for the temperature values.

DG-DEN-8030-1 17 Jun 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-11980-1 16 Feb 2022

RESOLVED.