•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-7135-1 05 Apr 2021

Is there protection in case the file is being written to while you are trying to read it? Doesn't QSettings do all of this for us already?

DG-DEN-8030-1 17 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 12 Apr 2021

Addressed.

DG-DEN-8030-1 16 Jun 2021

Should this flag be deleted since we no longer have any V2 DG?

DG-DEN-8030-1 17 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8030-1 21 Jun 2021

Mismatch description.

HD-DEN-9906-1 15 Nov 2021

Done.

DIALIN-DEN-7135-1 13 Apr 2021

RESOLVED.

UI-DEN-7044-1 13 Apr 2021

RESOLVED

UI-DEN-7044-1 07 Apr 2021

Thanks for doing this.
But that is not what I meant.
Struct Data should only have basic data types which require to be sending between threads.
What is implemented here is an immediate struct definition in a class which will be passed and is literally the same as a class and has the only overhead of a struct defined in the class.
Please use Data as the data and remove the functions from the struct Data.
I think the concept of having the struct Data is not clarified, let me know if I need to explain mor.

HD-DEN-9906-1 15 Nov 2021

Done.

HD-DEN-7395-1 14 Apr 2021

Addressed.

DG-DEN-5963-1 14 Apr 2021

Done.

HD-DEN-7395-1 13 Apr 2021

Can we clear this alarm when it is raised? If no, do we need this else statement? Because if the alarm has not been raised, we do not need to clear it either.

HD-DEN-7395-1 13 Apr 2021

Should AND this bit off from register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).
Should be something like fpgaActuatorSetPoints.fpgaSensorTest &= ~FPGA_BLOOD_LEAK_ZERO_CMD;

HD-DEN-9906-1 15 Nov 2021

RESOLVED in CODE WALKTHROUGH

DIALIN-DEN-11750-1 23 Feb 2022

Done.

HD-DEN-9906-1 15 Nov 2021

RESOLVED in CODE WALKTHROUGH

DG-DEN-9906-1 15 Nov 2021

RESOLVED in CODE WALKTHROUGH

DG-DEN-11750-1 25 Feb 2022

Add #ifndef RELEASE around this structure.

HD-DEN-11098-1 19 Nov 2021

Fixed

DIALIN-DEN-10602-2 15 Dec 2021

Fixed.
If Crucible doesn't show you the latest update please drag the comment slider (which is on top of the current file view) right knob to the right end under the last commit.

UI-DEN-10602-1 29 Nov 2021

Why commented out?

HD-DEN-11114-1 29 Nov 2021

Done.

HD-DEN-11098-1 18 Nov 2021

Why reset start time here?

HD-DEN-11750-2 02 Mar 2022

Magic #.

HD-DEN-11098-1 02 Dec 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11114-1 02 Dec 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11750-1 25 Feb 2022

This might have been updated in the different Dialin branch.

DG-DEN-11928-1 28 Feb 2022

Is 400 mL/min rate correct? I thought it was 800.

DG-DEN-11928-1 01 Mar 2022

Added a blank line.
Asked Dara to add acid and bicard values to the calibration record on 2/8/2022.

HD-DEN-11750-2 24 Feb 2022

Do these variables need to be volatile?

DIALIN-DEN-11750-1 01 Mar 2022

RESOLVED.

DG-DEN-11928-1 01 Mar 2022

Renamed #define to

#define MIN_WATER_TEMPERATURE_WARNING_LOW_RANGE 22U
#define MAX_WATER_TEMPERATURE_WARNING_LOW_RANGE 24U
#define MIN_WATER_TEMPERATURE_WARNING_HIGH_RANGE 37U
#define MAX_WATER_TEMPERATURE_WARNING_HIGH_RANGE 39U
#define MIN_WATER_TEMPERATURE_ALARM 22U
#define MAX_WATER_TEMPERATURE_ALARM 39U

DG-DEN-11750-1 02 Mar 2022

I will implement it in DEN-12224.

HD-DEN-11750-2 02 Mar 2022

They do not. Remove volatile from these declarations.

DG-DEN-11928-1 28 Feb 2022

What is the point of turning off the pumps here?

DG-DEN-11928-1 28 Feb 2022

Replace this out of range alarm with 2 separate alarms (as I stated above): 1) inlet water too high (>39) and inlet water too low (<22).

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-10602-2 15 Dec 2021

"final uf volume" and "final uf rate"

HD-DEN-11980-1 16 Feb 2022

Fixed. Thanks!

HD-DEN-8030-1 24 Jun 2021

Done

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

updated

HD-DEN-8030-1 24 Jun 2021

Done

HD-DEN-8103-1 21 Jun 2021

Add empty line before return.

UI-DEN-7135-1 05 Apr 2021

Don't think prepend("/") is needed here since according to https://doc.qt.io/qt-5/qfileinfo.html#absolutePath, "On Unix the absolute path will always begin with the root, '/', directory."

UI-DEN-8252-1 25 Jun 2021

Is it ready for review?

HD-DEN-9906-1 15 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-11980-1 17 Feb 2022

that'll be done in another sprint as ALL methods need to convert to that.

HD-DEN-7395-1 12 Apr 2021

RESOLVED in CODE WALKTHROUGH.