The code was old and not up to our standard. It was in the middle of a huge improvement and test. It has been completely removed from the screen and moved to the component to avoid redundant code copy/paste.
The code was old and not up to our standard. It was in the middle of a huge improvement and test. It has been completely removed from the screen and moved to the component to avoid redundant code copy/paste.
Should OR ( |= instead of = ) this bit into register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).
These functions are defined by macros and have the comment headers in macro and it has been set up in oxygen to grab the comments from the defined macro and not the implementation. So long story short, the comments for these methods onAttributeRequest & onProcessBluetoothPairedResetExitCode, will be inherited from macros. They are all overloaded function members (same name different signature)
These should probably go in calibration record - talk to Dara to get that started. Leave these here until it is ready. Also, add a blank line between public definitions comment and any #defines.
I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?
2000 uS/cm is a safe value to determine if the acid is inserted in. Due to sensor to sensor variations, we decided to keep it a little lower than its conductivity value is.
