•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-11980-1 16 Feb 2022

RESOLVED.

HD-DEN-9906-1 15 Nov 2021

RESOLVED in CODE WALKTHROUGH

DG-DEN-5963-1 14 Apr 2021

Done.

HD-DEN-13834-1 14 Oct 2022

0.0F (pwm) param not in function - remove.

HD-DEN-7395-1 14 Apr 2021

Addressed.

HD-DEN-7395-1 13 Apr 2021

Should OR ( |= instead of = ) this bit into register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).

HD-DEN-9906-1 15 Nov 2021

RESOLVED in CODE WALKTHROUGH

HD-DEN-11250-1 17 Feb 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8030-1 16 Jun 2021

Do we need this include?

HD-DEN-17093-1 16 Oct 2024

Done

DG-DEN-8030-1 17 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8030-1 16 Jun 2021

Why is this check removed?

DG-DEN-8030-1 16 Jun 2021

Target speed has to set to get direction going before turning the pumps on.

HD-DEN-11980-1 17 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8030-1 21 Jun 2021

Change the alarm to ALARM_ID_TREATMENT_STOPPED_NO_RINSEBACK

HD-DEN-8030-1 21 Jun 2021

Mismatch description.

DD-LEAH-225-1 16 Oct 2024

Should duty cycle be zeroed?

HD-DEN-8030-1 25 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8514-2 17 Jun 2021
  • That function doesn't use the UI message Id and is using dialin message-id enum which is not used in UI.
  • it doesn't get a parameter and is hardcoded.
  • I can remove that function if not being used anywhere else.
    Will take care of it in the code review of the next story.
HD-DEN-9906-1 15 Nov 2021

Added comment.

HD-DEN-11098-1 13 Dec 2021

Replaced by primeDialysateDialyzerTimeLimit because this variable is dynamic and based on the type of dialyzer.

HD-DEN-11114-1 29 Nov 2021

Cleaned up the message.

UI-DEN-10602-1 29 Nov 2021

This is a debug code that will be enabled to trace the screen stack.
if was only a return, changed to an if to make it conditional for later use.

UI-DEN-10602-1 29 Nov 2021

RESOLVED.

HD-DEN-11114-1 29 Nov 2021

Done.

HD-DEN-11098-1 18 Nov 2021

I think this needs to be closed or saline will not be forced across dialyzer into dialysate flow path.

HD-DEN-11114-1 29 Nov 2021

Remove the enum? Did this get moved somewhere?

HD-DEN-11114-1 29 Nov 2021

Why remove this later? Don't we need it?

HD-DEN-11114-1 02 Dec 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-10602-1 13 Dec 2021

it is a test for the code review demo

UI-DEN-10602-1 14 Dec 2021

Added

DIALIN-DEN-10602-2 15 Dec 2021

Thanks for pointing that out.
Fixed.

DIALIN-DEN-10602-2 15 Dec 2021

Start and End field positions are out of alignment for response as well.

DIALIN-DEN-10602-2 15 Dec 2021

My mistake. i was thinking the parameters 'origin_uf_rate' and 'origin_uf_volume' need to be reworded since its now the Prescribed Ultrafiltration volume/rate

DIALIN-DEN-10602-2 15 Dec 2021

The names for these new parameters are named "final uf volume" and "final uf rate" for treatment log based on discussion and PRS.

HD-DEN-11098-1 13 Dec 2021

This start time was last set in setup function - quite some time ago. So this will have immediately timed out the first time we get here. I think this still works though.

HD-DEN-11098-1 13 Dec 2021

Do we need separate start time variables? These are not used at same time - consider consolidating into a single variable.

HD-DEN-11098-1 13 Dec 2021

Why is this commented out?

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 11 Apr 2021

I imagine this state would need to look for zero to complete within some time period so we can tell FPGA to put sensor in self-test mode and set your state machine to self-test state. Fault if times out.

HD-DEN-13598-2 22 Sep 2022

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this test only runs on a release build.

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11980-1 16 Feb 2022

Fixed. Thanks!

DIALIN-DEN-7135-1 11 Apr 2021

Put the TODO comment

DIALIN-DEN-7135-1 11 Apr 2021

After the change in the messaging structure these codes were not working so I commented them out to let the simulator work.
But kept as the guidelines of how the implementation needs to change.
Also, there's a comment to update then with the new messaging.
Put the TODO comment.

HD-DEN-13834-1 14 Oct 2022

Removed again?

DG-DEN-8030-1 17 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 12 Apr 2021

Moved to common DGDefs.h (in staging branch).

HD-DEN-11980-1 17 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 12 Apr 2021

Addressed.