•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-6631-1 15 Feb 2021

These are currently unused, maybe they can be deleted?

HD-DEN-6372-1 16 Feb 2021

Remove doxygen comment.

DG-DEN-6402-1 17 Feb 2021

Why commented out?

DG-DEN-6402-1 17 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 17 Feb 2021

These has been uncommented.

HD-DEN-5887-1 19 Feb 2021

Why reduced control frequency update?

DIALIN-DEN-6890-1 11 Mar 2021

Addressed.

DIALIN-DEN-7091-1 12 Mar 2021

RESOLVED

HD-DEN-7091-1 22 Mar 2021

Why fabs() here?

HD-DEN-7091-1 22 Mar 2021

Shouldn't this be a bubble detector fault?

DG-DEN-7091-1 13 Mar 2021

Fixed.

HD-DEN-7091-1 15 Mar 2021

It was used to calculated how much to fill the first reservoir in mode pretreatment module, but not anymore.
Removed.

HD-DEN-7091-1 15 Mar 2021

Renamed to consumableInstallConfirmed for less confusing.

DG-DEN-7091-1 19 Mar 2021

Moved valves config to standby mode transition.

DG-DEN-7091-1 13 Mar 2021

conver should be convert. Flow is in L/min.

DIALIN-DEN-5980-1 12 Feb 2021

This function should be split up into functions that each have a single responsibility

DG-DEN-5980-1 21 Mar 2021

Because I used a different debugger and it updated the launch file. I think we should add this .gitignore.

DG-DEN-5980-1 21 Mar 2021

As a common practice, I use #pragma around the structs. Does that matter?

HD-DEN-7091-1 22 Mar 2021

Done.

HD-DEN-7091-1 22 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

Done.

UI-DEN-7035-1 24 Mar 2021

Great.
RESOLVED

HD-DEN-5980-1 21 Mar 2021

Remove this case. Its obsolete.

DIALIN-DEN-5980-1 17 Feb 2021

Same comment as DG accelerometer cal function.

DIALIN-DEN-5980-1 17 Feb 2021

Message length? Payload length?

UI-DEN-7035-1 24 Mar 2021

No problem with what has been done here, just please add some description on top to make it clear it is regarding that.
echo out is clear too.
RESOLVED.

UI-DEN-7044-1 31 Mar 2021

These are just thresholds by which to categorize the signal strength of an AP. So, the actual measured signal strength will vary independently of these levels.

HD-DEN-7347-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7135-1 01 Apr 2021

When I tried to test out your branch, I got a compilation error saying that DRY_SELF_TESTS_SYRINGE_PUMP_PRIME_STATE doesn't currently exist in HDDefs.h. My common has the latest changes

HD-DEN-7117-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 01 Apr 2021

Use 10 instead of ten (easier to track and compare).

HD-DEN-7117-1 06 Apr 2021

Spell out lc variable as loadCell.

HD-DEN-7117-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7135-1 06 Apr 2021

it is an alias name for ISO/IEC_8859-1 character encoding standard.
https://en.wikipedia.org/wiki/ISO/IEC_8859-1

HD-DEN-7117-1 06 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

The documentation has been managed in a way that this comment will be inherited from the parent class MAbstract, virtual function parameters(), so it doesn't need to be mentioned for each child.

    /*!
     * \brief   fromByteArray
     * \details converts the values from Byte Arrays to the Model data.
     * \param   vByteArray - the byte array input
     * \param   vIndex     - current index of each data section in byte array
     * \return  true on successful conversion
     */
    virtual bool         fromByteArray(const QByteArray   &vByteArray  , int *vIndex = nullptr)       = 0;
DIALIN-DEN-6078-1 20 Feb 2021

Done

DIALIN-DEN-6078-1 22 Feb 2021

RESOLVED

HD-DEN-11980-1 16 Feb 2022

Renamed to testSendCurrentTreatmentParameters(). thanks!

UI-DEN-7135-1 05 Apr 2021

Docstrings are missing in this class

DG-DEN-7091-1 01 Mar 2021

Removed.

HD-DEN-7091-1 28 Feb 2021

Where does this get set to TRUE? Who uses this flag?

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6372-1 03 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7135-1 12 Apr 2021

RESOLVED

HD-DEN-6890-1 09 Mar 2021

Addressed.

UI-DEN-7135-1 05 Apr 2021

Can this be deleted?

UI-DEN-7135-1 05 Apr 2021

Is this class really needed? QSettings is already thread-safe. What does this class do that QSettings doesn't already do?