Where did zeroBloodLeak() and selfTestBloodLeak() functions go? You have prototypes for them in .h and I think you still need at least one of them. zeroBloodLeak would be called by Pre-Treatment Mode and would tell FPGA to put sensor in zero state and would also put your state machine in zero state.
"Final Target Ultrafiltration Rate" for simplicity, the "Final" portion has been removed and only the "Target" is used since all SW knows them as "Target" only.
I added these already to staging, but they are named BUILD_FOR_DESKTOP and BUILD_FOR_TARGET. So when you merge staging to your branch or vice versa be sure to rename all of mine or make sure all of them are named the same since there's no need for duplicates. Also, are we still going to review merges as I don't think there is a merge commit yet from staging to this branch in this code review.
Instead of retry logic, should we just double the time out? This retry is essentially extended the time one more without any action to correct the first time out.
Yes, Sean and I thought that it would be good for the SWVV, SYSVV, MFR, and SVC Teams to know via Dialin API which state the Blood Leak state machine is in. This detector comes with an independent MCU thqat can be programmed and calibrated via UART and via HD FPGA including self-test mode and zeroing mode to zero the sensor when clear dialysate is run through it. Then a threshold of blood can be set to be detected as soon as blood gets across the dialyzer from the blood circuit to the dialysate circuit.
You are running release
CR4.8.14
FE4.8.14
(20240111091859 2024-01-11 09:20),
please report your release number when reporting bugs.