•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7091-1 22 Mar 2021

Fixed.

HD-DEN-5980-1 22 Mar 2021

fwcommon had to be updated with latest changes. It is un-commented.

DG-DEN-5980-1 23 Mar 2021

Uncomment code.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 22 Mar 2021

Create a build switch for this then.

DG-DEN-5980-1 22 Feb 2021

These cases should be in same order as enum.
POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So should this POST be executed earlier?

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

Is the blood leak self test fast enough to be done in less than 50 ms?

HD-DEN-7091-1 22 Mar 2021

Rename to "havePumpsStarted".
Set to FALSE in handleNoCartSelfTestStoppedState() so pumps will be restarted on resume.

DIALIN-DEN-5980-1 23 Mar 2021

Done.

DIALIN-DEN-5980-1 12 Feb 2021

self.DG_SYSTEM_RECORD is not a constant so it should be all lowercase instead of all caps (PEP8)

DG-DEN-5980-1 24 Mar 2021

Done.

UI-DEN-7035-1 24 Mar 2021

Done

UI-DEN-7035-1 24 Mar 2021

Done

UI-DEN-7035-1 24 Mar 2021

Sure, I've updated it to remove the chain of bindings

UI-DEN-7035-1 24 Mar 2021

This process is called in the main thread (GUI thread), and any issue will freeze the UI.
Let's talk about it before any decision.
I need to know more about the code structure.

DIALIN-DEN-5980-1 17 Feb 2021

Length of what?

HD-DEN-5980-1 24 Mar 2021

Add TODO.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8030-1 15 Jun 2021

Done.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 29 Jan 2021

I have updated .gitignore so only bledevices.conf is ignored since it will be different for each device.

DIALIN-DEN-5751-1 01 Feb 2021

Please refer to the general comment I put,
These codes are not maintained by UI.


The only files that were involved in these changesets are:

dialin/ui/hd_simulator.py
dialin/common/msg_defs.py
dialin/squish/denaliMessages.py
And all the other files are merged from master and other branches which were merged into master.

DD-LEAH-225-1 16 Oct 2024

Maybe add Control to end of function name.

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-6631-1 15 Feb 2021

there has to be two empty lines.
removed 1 of 3 lines.

UI-DEN-6631-1 16 Feb 2021

RESOLVED.

UI-DEN-6631-1 16 Feb 2021

Removed.

DG-DEN-5963-1 07 Apr 2021

This should be an or.

HD-DEN-7395-1 24 Mar 2021

Remove this. No need to add if there are no parameters.

HD-DEN-6372-1 16 Feb 2021

Consider changing 60 to SEC_PER_MIN.

HD-DEN-6890-1 11 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6890-1 10 Mar 2021

Do we need different states if the purpose is to trigger an alarm?

HD-DEN-7395-1 08 Apr 2021

Temperature values have been extracted out from treatment parameters in HD-DEN-7091.

DG-DEN-5963-1 08 Apr 2021

Did we want to mention "set" in the two variables' name?

HD-DEN-7117-1 19 Mar 2021

UF off and complete states are going to be removed. Removed case handlers and handler functions. Keeping enums until UI is updated to not use them.

HD-DEN-6453-1 19 Mar 2021

Removed comment.

UI-DEN-7135-1 10 Apr 2021

RESOLVED.

DG-DEN-7091-1 19 Mar 2021

Updated.

HD-DEN-7395-1 08 Apr 2021

What is the difference between this interval override and the one below? If monitor is broadcasting 2 different messages, why? Recommend combining published blood leak data into one message.

HD-DEN-7091-1 19 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 08 Apr 2021

Why commented out?

HD-DEN-7091-1 19 Mar 2021

Make it private function to this module and call from DG monitor function.

DG-DEN-7091-1 19 Mar 2021

Quang to address temperature in future branch. RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 21 Mar 2021

Uncommented the code.

DG-DEN-5980-1 21 Mar 2021

I will use the older message IDs for other programs.

DG-DEN-5980-1 23 Mar 2021

Update to new build switch.

DG-DEN-7091-1 22 Mar 2021

Added timeout.

HD-DEN-7091-1 22 Mar 2021

Done.