If DG somehow gets ahead of HD here, I worry we will get stuck. Consider second condition with "getDGSubMode() >= DG_FILL_MODE_STATE_BICARB_PUMP_CHECK". Same for states below.
Add blank line here. Also add comment for these if statements to describe the conditions. Looks like first if for when to end the test and second if is pass/fail criteria.
Please refer to the general comment I put, These codes are not maintained by UI.
The only files that were involved in these changesets are:
dialin/ui/hd_simulator.py dialin/common/msg_defs.py dialin/squish/denaliMessages.py And all the other files are merged from master and other branches which were merged into master.
Please refer to the general comment I put, These codes are not maintained by UI.
The only files that were involved in these changesets are:
dialin/ui/hd_simulator.py dialin/common/msg_defs.py dialin/squish/denaliMessages.py And all the other files are merged from master and other branches which were merged into master.