•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-5980-1 12 Feb 2021

The current_message, total_messages, length, and system record variables should be published

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

You asked for this change:


We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files.
Since the SD card might be damaged and we still need to store settings.
Please change it to refer to the application location and name the folder as configuration or settings.


Here's a screenshot: X:\Users\PeterL\ForBehrouz\settings.png

UI-DEN-5638-1 27 Jan 2021

Please change to TreatmentStates
RESOLVED

UI-DEN-5638-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

it may contain other settings so please don't ignore it in .gitignore.

UI-DEN-6349-1 13 Jan 2021

Please use macros for the connections, whenever possible.

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

will be done later.
RESOLVED

UI-DEN-6349-1 27 Jan 2021

needs to investigate more or done later.
RESOLVED

UI-DEN-5751-1 29 Jan 2021

What has caused this change in AUT_NAME?

UI-DEN-5751-1 29 Jan 2021

Should point to HDSimulator since denaliMessages has been deprecated

UI-DEN-5751-1 29 Jan 2021

Should point to the HDSimulator

DIALIN-DEN-11250-1 16 Feb 2022

RESOLVED.

UI-DEN-5751-1 29 Jan 2021

Should be

self.hd_simulator.alarms.cmd_activate_alarm_id
HD-DEN-12224-16 24 May 2022

This function is still available.

UI-DEN-5751-1 29 Jan 2021

denaliMessages has been deprecated. Please don't add it back to dialin. This should be

self.hd_simulator.alarms.cmd_set_alarm_triggered
UI-DEN-5638-1 26 Jan 2021

I will discuss with Peman and get back to you.

UI-DEN-5751-1 29 Jan 2021

These limits should reside next to the other treatment parameter defaults in TreatmentCreate.h.
Putting them in QML causes changes to the treatment parameters configuration file (specifically arterial and venous pressure limits) to have no effect.

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-5751-1 29 Jan 2021

here as well (see above)

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 27 Jan 2021

RESOLVED

UI-DEN-6349-1 08 Jan 2021

Very dangerous use of pointers please consider using none pointer variables.
as an example why _lastSelectedDevice has been defined as a pointer?
Please keep that in mind there is no guaranty that your code will reach the pointer release, and exceptions can happen anytime.

UI-DEN-5751-1 29 Jan 2021

Should be

self.hd_simulator.set_treatment_heparin_data(volume)
UI-DEN-6349-1 27 Jan 2021

Resolved as per our code review 1.27.2021

UI-DEN-5751-1 29 Jan 2021

Can delete

UI-DEN-6349-1 27 Jan 2021

will be done later.
RESOLVED

UI-DEN-6349-1 27 Jan 2021

will be done later.
RESOLVED

UI-DEN-6349-1 11 Jan 2021

Thanks for providing the screenshots to compare.
I would vote for the default style which covers half the screen since it is more standard and would be the same all over the application instead of having different keyboard combinations and locations in different situations and prefer to relocate screen components and labeling to fit in the screen.
It can be like :

                                  Vitals Entry
                                ------------------
   systolic [   ___    ]        diastolic [   ___    ]        BPM [   ___    ]

(or labels at top)


and hide the keyboard on last entry BPM, 'enter' touch.
Also, please on the user 'enter' touch go to the next entry.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6372-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6372-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 01 Feb 2021

RESOLVED

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5751-1 01 Feb 2021

RESOLVED.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6453-1 01 Feb 2021

Already there - see line 32.

HD-DEN-6453-1 29 Jan 2021

I would add a TODO on this entire section to be removed for production. After P-BETA v0.6 is built, there will be no need for this.

HD-DEN-6453-1 01 Feb 2021

RESOLVED in CODE WALKTHROUGH.