LEAHI-DD-FIRMWARE-LDT-1196 LEAHI-DD-FIRMWARE-LDT-1196

2:59 pm

Vinayakam Mani and Raghu Kallala

More
LEAHI-DD-FIRMWARE-LDT-1196-8
finished reviewing

2:15 pm

jpaguio (deleted user)

2:15 pm

jpaguio (deleted user)

More
Re: LEAHI-DD-FIRMWARE-LDT-1196-6
commented on review

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

2:13 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-1196-8
started review

LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate

11:01 am

Sean Nash and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-1196-6
resumed reviewing

1:33 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1196-6
replied to jpaguio (deleted user)

RESOLVED IN CODE WALKTHROUGH.

11:45 am

jpaguio (deleted user)

Done

11:45 am

jpaguio (deleted user)

Done

11:45 am

jpaguio (deleted user)

Done

11:44 am

jpaguio (deleted user)

Done

11:44 am

jpaguio (deleted user)

Done

9:45 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-1196-6
commented on review

Appears to be dialysate to dialyzer flow rate.

9:44 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-1196-6
commented on review

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cas...

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cases. Consider changing variable name to something like dialysateToDialyzerFlowRate and updating function description in header to make this more clear.

9:39 am