LEAHI-DD-FIRMWARE-LDT-2030

LEAHI-DD-FIRMWARE-LDT-2030

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 6
Total Commits: 3,336
Last Commit: 20 Mar
Commits this week: 6

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 12 Feb
4:56 pm

Vendor - TEL - Jashwant Gantyada

4:55 pm

Sean Nash and Vendor - TEL - Sameer Poyil

2:02 pm

Sean Nash

Can these be done without loop (just fix the size to cover both columns of the array)?

Can these be done without loop (just fix the size to cover both columns of the array)?

2:01 pm

Sean Nash

This memset should be deleted since handled above in loop now.

This memset should be deleted since handled above in loop now.

2:00 pm

Sean Nash

Add a blank line after declaration.

Add a blank line after declaration.

1:54 pm

Vendor - TEL - Sameer Poyil

implement it in a single structure packing by moving all other pragma pack

implement it in a single structure packing by moving all other pragma pack

1:50 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

declared in the header and updated them.

declared in the header and updated them.

1:43 pm

Vendor - TEL - Jashwant Gantyada

Resolved. Thanks

Resolved. Thanks

1:43 pm

Vendor - TEL - Jashwant Gantyada

Resolved. Thanks

Resolved. Thanks

Wednesday 11 Feb
2:30 pm

Sean Nash

We can but not necessary - only necessary when using == operator.

We can but not necessary - only necessary when using == operator.

2:29 pm

Vendor - TEL - Arpita Srivastava

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

2:23 pm

Vendor - TEL - Arpita Srivastava

Minor: There is a typo with Inputs

Minor: There is a typo with Inputs

1:34 pm

Sean Nash

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

1:33 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:33 pm

Sean Nash

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

1:31 pm

Sean Nash

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

1:28 pm

Sean Nash

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

1:26 pm

Sean Nash

Actually, for casting, I prefer no spaces around ().

Actually, for casting, I prefer no spaces around ().

1:25 pm

Sean Nash

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

12:01 pm

Vendor - TEL - Arpita Srivastava

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function. Should we add bloodLeakEmbModeCmdQ to the list?

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function.
Should we add bloodLeakEmbModeCmdQ to the list?

11:53 am

Vendor - TEL - Arpita Srivastava

Please change bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE to BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

Please change

bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE
to
BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState