LEAHI-DD-FIRMWARE-LDT-3222

LEAHI-DD-FIRMWARE-LDT-3222

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,365
Last Commit: 17 Apr
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 09 Feb
1:39 pm

Dara Navaei

1:34 pm

Sean Nash , Michael Garthwaite and Vendor - TEL - Sameer Poyil

1:30 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
10:59 am

Vendor - TEL - Arpita Srivastava

Friday 06 Feb
3:34 pm

Vinayakam Mani

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

2:08 pm

Vendor - TEL - Arpita Srivastava

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE...

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE_PAYLOAD_T. Because of the mismatch is payload type, we cannot use the function u32ArrayOverride in this case.

1:39 pm

Vendor - TEL - Arpita Srivastava

We can update this function as part of another Jira ticket.

We can update this function as part of another Jira ticket.

1:21 pm

Sean Nash

This one looks like maybe we could use the helper function. Have Vinay look at it.

This one looks like maybe we could use the helper function. Have Vinay look at it.

1:20 pm

Sean Nash

I don't think so. The state is bit encoded, so special handling is required.

I don't think so. The state is bit encoded, so special handling is required.

Tuesday 03 Feb
5:02 pm

Vendor - TEL - Sameer Poyil

This function also not using u32ArrayOverride()

This function also not using u32ArrayOverride()

5:01 pm

Vendor - TEL - Sameer Poyil

is it possible to use the function u32ArrayOverride() here ?

is it possible to use the function u32ArrayOverride() here ?

4:48 pm

Sean Nash

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint. The description of their issue suggests that the 8 BC...

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

4:41 pm

Sean Nash

I don't think mask or pos require initialization either.

I don't think mask or pos require initialization either.

4:38 pm

Sean Nash

I don't think valve needs to be initialized here. The for loop initializes it.

I don't think valve needs to be initialized here. The for loop initializes it.