LEAHI-DIALIN-LDT-2004

LEAHI-DIALIN-LDT-2004

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 1
Total Commits: 3,393
Last Commit: 18 Jun
Commits this week: 1

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 11 Jun
1:29 pm

Sean Nash

Tuesday 02 Jun
9:33 am

Zoltan Miskolci

Please update this section based on the newest staging. If you try to merge it like this it will cause inconsistencies.

Please update this section based on the newest staging. If you try to merge it like this it will cause inconsistencies.

Monday 01 Jun
11:33 am

Vinayakam Mani

fix the typo.

fix the typo.

11:33 am

Vinayakam Mani

Delta instead of target conductivity?

Delta instead of target conductivity?

Thursday 21 May
11:22 am

Dara Navaei

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
Friday 13 Feb
9:37 am

Vinayakam Mani

Tuesday 10 Feb
1:33 pm

Vendor - TEL - Sameer Poyil , Sean Nash and Zoltan Miskolci

11:23 am

Vendor - TEL - Sameer Poyil

merged staging into dry bicart branch and code is pushed

merged staging into dry bicart branch and code is pushed

11:22 am

Vendor - TEL - Sameer Poyil

New code pushed

New code pushed

9:29 am

Zoltan Miskolci

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place Broadcast -> cmd_generic_broadcast_interval_override others -> cmd_generic_ov...

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

9:26 am

Zoltan Miskolci

This is not the code that is currently on staging, so I think you need to update it from there

This is not the code that is currently on staging, so I think you need to update it from there

Monday 09 Feb
8:57 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

5:55 pm

Vendor - TEL - Sameer Poyil

This is a change from Zoltan and I am updated that into my local branch

This is a change from Zoltan and I am updated that into my local branch

Friday 06 Feb
8:18 pm

Vendor - TEL - Sameer Poyil

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

8:15 pm

Vendor - TEL - Sameer Poyil

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

10:41 am

Sean Nash

Add a blank line between functions.

Add a blank line between functions.

9:37 am

Sean Nash

Is this staying? Is all of above replacing this class?

Is this staying? Is all of above replacing this class?

Tuesday 03 Feb
2:05 pm

Zoltan Miskolci

Based on the msg id, it should be here

Based on the msg id, it should be here

1:30 pm

Vendor - TEL - Sameer Poyil

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

11:54 am

Michael Garthwaite

9:09 am

Zoltan Miskolci

Please pull the latest staging and update the test configs regarding that. I think the dry bicart test config is already there

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

Tuesday 27 Jan
10:07 am

Michael Garthwaite

9:24 am

Zoltan Miskolci

9:20 am

Michael Garthwaite

updated to use the generic override. Both of you are correct, the generic override can be used. Since we pack the payload outside of the generic override, for this situation we don't pack the res...

updated to use the generic override.

Both of you are correct, the generic override can be used.

Since we pack the payload outside of the generic override, for this situation we don't pack the reset byte and therefore will stay as a U32 which satisfies the FW constraint. The other concern I had was that the FW would not reply back with a test ACK back to dialin with this cmd, thus causing a timeout in the generic override function. This is address as all messages in the lookup table in FW will reply back with a test ACK.

Therefore im okay using the generic override method

Monday 26 Jan
10:46 pm

Sean Nash

10:45 pm

Sean Nash

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

3:13 pm

Zoltan Miskolci

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue. you are sending a message with this msg id and this p...

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue.
you are sending a message with this msg id and this payload, if the FW is expecting that, then it will work.

Should I rename the cmd_generic_override to like cmd_generic_message_sender to be less confusing?

12:31 pm

Michael Garthwaite

fixed writing over the error count override. Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_...

fixed writing over the error count override.

Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_T.

the generic override will cause the FW to always reject the value since the payload size is not what is expected.

12:26 pm

Zoltan Miskolci

Can't we use the generic override? You just need to update 3 fields: msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST entity_name = 'DD Coductivity sensor model request' override_text = 'S...

Can't we use the generic override?
You just need to update 3 fields:

msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST
entity_name = 'DD Coductivity sensor model request'
override_text = 'Sent' or ''

12:16 pm

Dara Navaei

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD