application / sources

canbus

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 03 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Aug 2022
11:54 pm

Behrouz NematiPour

DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x9B]

- Implemented the disinfection mode response

Options
    • -0
    • +1
    ./MessageInterpreter.cpp
  2. … 11 more files in changeset.
11:14 pm

Behrouz NematiPour

DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x80]

- Renamed the disinfection start response

Options
    • -1
    • +1
    ./MessageInterpreter.cpp
  2. … 5 more files in changeset.
9:51 pm

Behrouz NematiPour

DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x9A]

- Implemented the Disinfection Mode Request message.

Options
    • -0
    • +13
    ./MessageDispatcher.cpp
    • -0
    • +1
    ./MessageDispatcher.h
    • -1
    • +3
    ./MessageGlobals.h
    • -0
    • +1
    ./MessageInterpreter.cpp
  5. … 7 more files in changeset.
8:25 pm

Behrouz NematiPour

DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x7F,0x80]

- Cleaned up / refactor the messages [ 127 (0x7F), 128 (0x80) ]

Options
    • -2
    • +2
    ./MessageDispatcher.cpp
    • -1
    • +1
    ./MessageDispatcher.h
    • -2
    • +2
    ./MessageGlobals.h
    • -2
    • +2
    ./MessageInterpreter.cpp
  5. … 13 more files in changeset.
Monday 15 Aug 2022
10:43 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x7E00]

- Removed

0x7E00 126 0x040 1 Hz N HD All Standby (disinfect) State "sub-mode (U32-enum) {

0-Flush, (No Flush State required for this state)

1-Heat Disinfect,

2-Chem Disinfect }" (U32) Flush State (U32) Heat Disinfect State (U32) Chem Disinfect State

Options
    • -1
    • +0
    ./MessageGlobals.h
    • -3
    • +0
    ./MessageInterpreter.cpp
  3. … 10 more files in changeset.
10:20 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x8200]

- Removed

0x8200 130 0x020 Rsp Y HD UI Chemical Disinfect User Confirm Response (U32) 1=accepted, 0=rejected (U32) rejection reason

Options
    • -1
    • +0
    ./MessageGlobals.h
    • -2
    • +0
    ./MessageInterpreter.cpp
  3. … 5 more files in changeset.
10:09 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x8100]

- Removed

0x8100 129 0x100 Req Y UI HD Chemical Disinfect User Confirm

Options
    • -12
    • +0
    ./MessageDispatcher.cpp
    • -1
    • +0
    ./MessageDispatcher.h
    • -1
    • +0
    ./MessageGlobals.h
    • -1
    • +0
    ./MessageInterpreter.cpp
  5. … 9 more files in changeset.
9:50 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x8500]

- Removed

0x8500 133 0x070 1 Hz N DG UI DG Chem Disinfect Time [each sub state] (U32) Timeout (secs) (0=no time estimate) (U32) Timeout countdown (secs)

Options
    • -1
    • +0
    ./MessageGlobals.h
    • -3
    • +0
    ./MessageInterpreter.cpp
  3. … 5 more files in changeset.
9:41 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x8400]

- Removed

0x8400 132 0x070 1 Hz N DG UI DG Heat Disinfect Time [each sub state] (U32) Timeout (secs) (0=no time estimate) (U32) Timeout countdown (secs)

Options
    • -1
    • +0
    ./MessageGlobals.h
    • -1
    • +0
    ./MessageInterpreter.cpp
  3. … 5 more files in changeset.
9:30 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x8300]

- removed the message:

|0x8300| 131| 0x070| 1 Hz| N| DG| UI| DG Flush Time [each sub state] |(U32) Timeout (secs) (0=no time estimate)| (U32) Timeout countdown (secs)|

Options
    • -1
    • +0
    ./MessageGlobals.h
    • -1
    • +0
    ./MessageInterpreter.cpp
  3. … 10 more files in changeset.
8:47 pm

Behrouz NematiPour

DEN-13645: IMP: Unhandled messages duplicate keys fix

- it has been observed that the unhandled messages are not logged correctly and turned out it is because of the Types of each parameter used as keys and keys can't be duplicate by default which caused issue for the unhandled messages, since they may have 6 parameter and all with F32 type which then becomes one parameter of type F32.

- an attribute has been defined for the config file with the format:

#--duplicate_key_on

#--duplicate_key_off

to allow or disallow the duplicate key at any point in the config file.

- Note that the save config parameters are always unique key like AlarmVolume which doesn't make sense to have duplicate entry.

Options
    • -1
    • +1
    ./MessageInterpreter.cpp
  2. … 9 more files in changeset.
Friday 12 Aug 2022
5:39 pm

Behrouz NematiPour

DEN-13645: IMP: General Implementation [-k, -K]

- The logic for the check-in and Ack messages reversed to be always disabled and can be enabled later if needed.

- For Integration/Unit tests the application needs to be called with these two switches otherwise tests will fail.

Options
    • -4
    • +4
    ./MessageDispatcher.cpp
    • -1
    • +1
    ./MessageInterpreter.cpp
  3. … 4 more files in changeset.
Wednesday 03 Aug 2022
11:10 pm

Behrouz NematiPour

DEN-13645: IMP: General Implementation

DEN-13447: UI able to send its final POST result to HD by request

Options
    • -0
    • +3
    ./MessageDispatcher.h
    • -0
    • +1
    ./MessageGlobals.h
    • -0
    • +1
    ./MessageInterpreter.cpp
  4. … 9 more files in changeset.
2:59 am

Behrouz NematiPour

DEN-13489 IMP: General Implementation

DEN-13035: Update alarm body messages

- Removed the exclamation mark icon form the Alarm Dialog.

- Removed the exclamation mark icon form the Alarm Bar.

- Made the whole AlarmDialog title bar doubleClick and diagnostics opener if the alarm is not minimizable.

- Moved the Alarm ID from title to the bottom left of the dialog with format: "ID:<id>".

- Clipped the AlarmDialon body message area, crop the text if longer than dialog area.

- Changed the "settings" property name of the VSettings to "instructions".

- Changed the date/time formats keys to simplify the code and conf file.

- Implemented the Alarm Body messages, to load from Alams/Alarms.conf, instead of the FW.

- The FW texts/documents will still being used if the Alarms.conf doesn't have a definition.

- A instruction base capability has also been added to the MVC, but UI still not supporting it.

Options
    • -3
    • +3
    ./MessageInterpreter.cpp
  2. … 18 more files in changeset.
Tuesday 26 Jul 2022
12:20 am

Behrouz NematiPour

DEN-13489: IMP: General Implementation for any bugs and any other implementations

- Enable Dialin logging CL switch has changed to disable dialin logging, to make the dialin logging as enabled by default and removed -d from run.sh. [Sean's Request]

- Added log unhandled as error to the unhandled reader as well.

- Implemented the NoCANBus to be used when no CANBus enabled. For now it is only bypassing the create treatment button command and helps to get to the treatment parameters for the touchscreen test. [EEMN's Support]

- Fixed a bug on the Volume Adjustment on post, sending to HD to update HD alarm volume with previous, adjusted value, which was sending a request one again receiving HD response, and it was a potential crash loop.

- Added disable acknowledgment logs (req,bak) CL switch, -K : --disable-acknow-log [Sean's Request]

Options
    • -5
    • +5
    ./FrameInterface.cpp
    • -9
    • +9
    ./MessageDispatcher.cpp
    • -1
    • +3
    ./MessageInterpreter.cpp
  4. … 12 more files in changeset.
Monday 25 Jul 2022
6:44 pm

Behrouz NematiPour

DEN-13489 IMP: General Implementation

DEN-12838: UI shall store the latest alarm volume and resend that to HD on POST

DEN-11539: Service password initial setup

Options
    • -2
    • +1
    ./MessageDispatcher.cpp
  2. … 12 more files in changeset.
Tuesday 12 Jul 2022
11:52 am

Sean Nash

11:51 am

Sean Nash

RESOLVED.

RESOLVED.

Monday 11 Jul 2022
10:01 am

Behrouz NematiPour

Sure Sean, if that is the decision, will do it soon and create a case for that. I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CA...

Sure Sean, if that is the decision, will do it soon and create a case for that.
I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CANBus).

Issue DEN-13441 - MR: Make the Dialin log permanent with no switch [CL switches review/removal] has been successfully created

Wednesday 06 Jul 2022
9:35 am

Sean Nash

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin comm...

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin commands are always one-shot type messages, so will not impact log size.

9:31 am

Sean Nash

RESOLVED.

RESOLVED.

9:31 am

Sean Nash

RESOLVED.

RESOLVED.

9:03 am

Tiffany Mejia

RESOLVED

RESOLVED

Tuesday 05 Jul 2022
10:19 am

Behrouz NematiPour

This code is going to be used later in the Log Export for slow transfer & confirmation for the USB port slow transfer issue. I kept it in the application repo to keep it safe. Commented out to not ...

This code is going to be used later in the Log Export for slow transfer & confirmation for the USB port slow transfer issue.
I kept it in the application repo to keep it safe.
Commented out to not affect the coverage.

Friday 01 Jul 2022
4:46 pm

Behrouz NematiPour

http://dvm-linux02:8060/cru/#UI-DEN-12716-2CFR-30978 in PostTreatmentReview.qml@40

http://dvm-linux02:8060/cru/#UI-DEN-12716-2CFR-30978
in PostTreatmentReview.qml@40

4:09 pm

Tiffany Mejia

Where would this value change?

Where would this value change?

11:46 am

Behrouz NematiPour

At the moment I added that switch I assumed it should only be used for V&V and SysV testing.

At the moment I added that switch I assumed it should only be used for V&V and SysV testing.

11:42 am

Behrouz NematiPour

This is the requirement. PRS 417: The HD Device manufacturing default timezone shall be (UTC-08:00) Pacific Time.

This is the requirement.
PRS 417: The HD Device manufacturing default timezone shall be (UTC-08:00) Pacific Time.

10:59 am

Sean Nash

Why is main.cpp all commented out?

Why is main.cpp all commented out?

10:57 am

Sean Nash

All systems will be setup for Pacific time zone?

All systems will be setup for Pacific time zone?