dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3103 addressed code review comments

    • -5
    • +4
    /firmware/App/Modes/ModeGenDialysate.c
LDT-3750 cherry-picked 3bafab7

    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
Vinayakam Mani had it removed. Can you please let us know why you have this commented out in latest staging?

Vinayakam Mani had it removed. Can you please let us know why you have this commented out in latest staging?

done. added a TODO.

done. added a TODO.

I have added the mentioned ones.

I have added the mentioned ones.

done.

done.

done.

done.

done.

done.

done

done

done

done

added a todo.

added a todo.

removed.

removed.

LDT-3344 addressed code review comments

    • -37
    • +22
    /firmware/App/Controllers/RinsePump.c
we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

LDT-3552 added a #define for the blood leak response buffer

    • -1
    • +3
    /firmware/App/Drivers/BloodLeakDriver.h
LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages
LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages
Vinay, based on your work with rinsepump, Do you have any persistence value in mind?

Vinay, based on your work with rinsepump, Do you have any persistence value in mind?

LDT-3344 set D79 to default PWM to 45%

LDT-3218: init commit to have flow curve based on recovery settings.

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow

Can we check some persistence before declaring alarm?

Can we check some persistence before declaring alarm?

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

LDT-3352 resolving merge conflicts

    • -4
    • +1
    /firmware/App/Modes/ModeGenDialysate.c
Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode? Even if all dialysate heating is done in this mode, should we consider cr...

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

Resolve merge conflicts.

Resolve merge conflicts.

LDT-3372: Reduced warnings in relation to teensy driver. Removed unused functions. Fixed overrides

    • -131
    • +28
    /firmware/App/Drivers/ConductivityTeensy.c
LDT-3344 addressed code review comments

    • -8
    • +119
    /firmware/App/Controllers/RinsePump.c