Activity dd-firmware/

1:41 pm

Vendor - TEL - Jashwant Gantyada

More
b85c96b
changed 3 files
LDT-3344-firmware-support-for-beta-2-fpg LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 addressed code review comments

- -21
- +1
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c
- -19
- +9
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -9
- +8
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h

12:50 pm

Raghu Kallala

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

11:03 am

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6). We still need test configs for beta 1.0 stuff and non-fpga differences. We can use DD fpga ID # here in this macro instead of t...

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6).
We still need test configs for beta 1.0 stuff and non-fpga differences.
We can use DD fpga ID # here in this macro instead of test config.
Since this is all temporary, I'm not that concerned about how we do this so long as it works.

10:22 am

Sean Nash

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff. I agree, but didn't comm...

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff.
I agree, but didn't comment on it because it's all temporary anyway.

9:59 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

9:46 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Move this up to public definitions section.

9:41 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-1477-1
commented on review

These don't need to be initialized.

9:17 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Outputs is none now I think.

8:13 am

Raghu Kallala

More
eec980c
changed 1 file
LDT-3344-firmware-support-for-beta-2-fpg LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 fixed typo in function hheader

- -1
- +1
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c

7:59 am

Raghu Kallala

readFloaterLevelStatus is higher level functions that give the data from the FPGA. Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandab...

readFloaterLevelStatus is higher level functions that give the data from the FPGA.
Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandable enum values (low, medium, high)

7:55 am

Raghu Kallala

This is a reset call, as the default requirement is to be on Beta 1.9 HW The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA r...

This is a reset call, as the default requirement is to be on Beta 1.9 HW
The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA registers

1:05 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cas...

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cases instead of multiple functions.

12:29 am