Activity dd-firmware/

9 hrs ago

Vendor - TEL - Jashwant Gantyada

More
ac5e52d
changed 5 files
LDT-3103-implement-closed-loop-control-f LEAHI-DD-FIRMWARE-LDT-3103-1

LDT-3103 implemented new pump changes

- -2
- +2
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -2
- +2
/firmware/App/Controllers/BalancingChamber.h
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.h
- -27
- +129
/firmware/App/Controllers/DialysatePumps.c
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.c
- -13
- +6
/firmware/App/Controllers/DialysatePumps.h
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.h
- -8
- +25
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

9 hrs ago

Michael Garthwaite

More
014d552
changed 1 file
LDT-3218-update-iofp-permeate-target-flow LEAHI-DD-FIRMWARE-LDT-3218-3

LDT-3218: fp tuning. WIP

- -4
- +4
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c

10 hrs ago

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean Nash Michael Garthwaite please confirm

10 hrs ago

Raghu Kallala

More
64acabc
changed 8 files
LDT-3603-ability-to-set-operation-sub-mo LEAHI-DD-FIRMWARE-LDT-3603-1

LDT-3603 converted all signal functions to void functions

- -6
- +2
/firmware/App/Modes/FPModes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.c
- -1
- +1
/firmware/App/Modes/FPModes/ModeGenPermeate.h
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.h
- -6
- +2
/firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/App/.../ModeGenPermeateDefeatured.c
- -1
- +1
/firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.h
- History
- Source
- Diff
/firmware/App/.../ModeGenPermeateDefeatured.h
- -10
- +2
/firmware/App/Modes/FPModes/ModePreGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.c
- -1
- +1
/firmware/App/Modes/FPModes/ModePreGenPermeate.h
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.h
- -6
- +2
/firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/.../ModePreGenPermeateDefeatured.c
- -1
- +1
/firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.h
- History
- Source
- Diff
/firmware/.../ModePreGenPermeateDefeatured.h

10 hrs ago

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

10 hrs ago