dd-firmware

Clone Tools

Stats

Commits this week: 62
Total Committers: 15
Last Commit: 14:06
Commits this week: 62

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
3 hrs ago

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Monitors/BloodLeak.c
3 hrs ago

Dara Navaei

3 hrs ago

Dara Navaei

Merged LDT-3605

Options
4 hrs ago

Sean Nash and Vendor - TEL - Jashwant Gantyada

7 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-3103 pressure range check for diff qd for d48 pump

Options
    • -2
    • +30
    /firmware/App/Controllers/BalancingChamber.c
8 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
8 hrs ago

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Drivers/ConductivityTeensy.c
    • -1
    • +1
    /firmware/App/Drivers/ConductivityTeensy.h
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.c
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.h
    • -2
    • +2
    /firmware/App/Monitors/Temperature.c
9 hrs ago

Michael Garthwaite

Merge branch 'LDT-3372-v1-conductivity-fixes' into staging

Options
Saturday 07 Mar
3:22 pm

Dara Navaei

3:09 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3605_(DD) BLD sensor intermittently does not read for B2.0 HW
LEAHI-DD-FIRMWARE-LDT-3605_(DD) BLD sensor intermittently does not read for B2.0 HW
3:06 pm

Dara Navaei

LDT-3605 updated the blood leak driver for the hardware config restart

Options
    • -13
    • +1
    /firmware/App/Monitors/BloodLeak.c
2:40 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Friday 06 Mar
7:00 pm

Vendor - TEL - Sameer Poyil and Sean Nash

2:48 pm

Sean Nash

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

2:46 pm

Sean Nash

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request. We should do whatever is needed (if an...

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

2:42 pm

Sean Nash

We shouldn't request op mode until we're sure we're happy with the whole thing. Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just re...

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

2:38 pm

Sean Nash

Declarations should be at top of scope (right before memcpy).

Declarations should be at top of scope (right before memcpy).

2:37 pm

Sean Nash

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

2:36 pm

Sean Nash

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

2:34 pm

Sean Nash

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

2:29 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +0
    /firmware/App/Monitors/Conductivity.c
2:25 pm

Michael Garthwaite

fixed

fixed

2:24 pm

Michael Garthwaite

fixed

fixed

2:24 pm

Michael Garthwaite

fixed.

fixed.

2:24 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -2
    • +0
    /firmware/App/Drivers/ConductivityTeensy.c
2:23 pm

Michael Garthwaite

fixed.

fixed.

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:22 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.c