dd-firmware

Clone Tools

Stats

Commits this week: 67
Total Committers: 16
Last Commit: 12 Mar
Commits this week: 67

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Mar
1:55 pm

Michael Garthwaite

LDT-2004: reverted 2.0 fpga init changes.

Options
    • -2
    • +2
    /firmware/App/Monitors/Conductivity.h
    • -1
    • +1
    /firmware/App/Services/FpgaDD.c
1:52 pm

Michael Garthwaite

LDT-2004: override fixes for v1 and v2 sensors.

Options
    • -135
    • +12
    /firmware/App/Drivers/ConductivitySensors.c
    • -4
    • +4
    /firmware/App/Drivers/ConductivitySensors.h
    • -3
    • +3
    /firmware/App/Drivers/ConductivityTeensy.c
    • -0
    • +73
    /firmware/App/Monitors/Conductivity.c
    • -0
    • +2
    /firmware/App/Monitors/Conductivity.h
    • -15
    • +8
    /firmware/App/Services/Messaging.c
1:48 pm

Sean Nash

FALSE?

FALSE?

1:46 pm

Vinayakam Mani

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

1:37 pm

Vinayakam Mani

are we using this variable, if not, can we remove across the file?

are we using this variable, if not, can we remove across the file?

1:35 pm

Vinayakam Mani

Add comment

Add comment

1:34 pm

Vinayakam Mani

Remove the unused macros.

Remove the unused macros.

1:32 pm

Vendor - TEL - Jashwant Gantyada

fixed.

fixed.

1:31 pm

Vendor - TEL - Jashwant Gantyada

added.

added.

1:31 pm

Vendor - TEL - Jashwant Gantyada

deleted

deleted

1:31 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:31 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:31 pm

Vendor - TEL - Jashwant Gantyada

changed and updated all the other places.

changed and updated all the other places.

1:31 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

1:30 pm

Vendor - TEL - Jashwant Gantyada

handled accordingly.

handled accordingly.

1:30 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:30 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:30 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:29 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:14 pm

Raghu Kallala

LDT-3603 changed code to return false when pause state is requested.

Options
    • -1
    • +4
    /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
    • -1
    • +4
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +4
    /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
12:22 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments and changes

Options
    • -27
    • +26
    /firmware/App/Controllers/BalancingChamber.c
    • -74
    • +38
    /firmware/App/Controllers/DialysatePumps.c
    • -2
    • +2
    /firmware/App/Controllers/DialysatePumps.h
    • -1
    • +0
    /firmware/App/DDCommon.h
    • -3
    • +16
    /firmware/App/Modes/ModeGenDialysate.c
    • -5
    • +3
    /firmware/App/Services/FpgaDD.c
11:59 am

Michael Garthwaite

LDT-2004: fixes to v2 conductivity sensors during unit 5 bring up

Options
    • -17
    • +19
    /firmware/App/Drivers/ConductivitySensors.c
10:50 am

Sean Nash

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

10:48 am

Sean Nash

Fix alignment of "=".

Fix alignment of "=".

10:47 am

Sean Nash

Add a param line in this header.

Add a param line in this header.

10:47 am

Sean Nash

Can we delete this commented out line?

Can we delete this commented out line?

10:46 am

Sean Nash

Add a params line in function header.

Add a params line in function header.

10:45 am

Sean Nash

Why did we change this spelling? Now it's wrong.

Why did we change this spelling? Now it's wrong.

10:44 am

Sean Nash

Can we delete this commented out line?

Can we delete this commented out line?

10:43 am

Sean Nash

Keep this blank line.

Keep this blank line.