Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 31

Total Committers:	16
Last Commit:	13:36
Commits this week:	31

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 13 Mar

9:38 am

Vendor - TEL - Arpita Srivastava

More
a42ea76
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd and 20 more LEAHI-DD-FIRMWARE-LDT-1195-2

LDT-1195: Updated function comments and requestBalChamberSwitching

- -4
- +12
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -2
- +0
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

9:33 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Remove extra blank line.

Remove extra blank line.

9:31 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

9:28 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

9:24 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

9:16 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Remove blank line.

Remove blank line.

8:57 am

chaithra bs <ven.cburudugatta@diality.com>

More
1d7e78f
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-dosing-control--dd and 25 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added testcases for TemperatureSensors file

7:09 am

Reddaiah Utti <ven.ureddaiah@diality.com>

More
120903a
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-dosing-control--dd and 25 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for Heaters.c file

7:05 am

Reddaiah Utti <ven.ureddaiah@diality.com>

More
3f66864
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-dosing-control--dd and 25 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for InternalADC.c file

Thursday 12 Mar

10:01 pm

Vendor - TEL - Praneeth Bunne

9:59 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

9:59 pm

Vendor - TEL - Jashwant Gantyada

removed from everywhere

removed from everywhere

9:58 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

9:58 pm

Vendor - TEL - Jashwant Gantyada

More
d056502
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 35 more LEAHI-DD-FIRMWARE-LDT-3103-1

LDY-3103 addressed code review comments

- -20
- +1
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c

9:58 pm

Vendor - TEL - Jashwant Gantyada

More
6299598
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 31 more

LDY-3103 addressed code review comments

- -20
- +1
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c

7:25 pm

Dara Navaei

More
c55f70a
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 35 more LEAHI-DD-FIRMWARE-LDT-3103-1

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

7:25 pm

Dara Navaei

More
4aad15a
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 31 more

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

7:25 pm

Dara Navaei

More
c5d66cf
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 35 more LEAHI-DD-FIRMWARE-LDT-3103-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h

7:25 pm

Dara Navaei

More
4800a1f
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 31 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h

6:14 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

5:24 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done

done

5:24 pm

Vendor - TEL - Jashwant Gantyada

changed accordingly.

changed accordingly.

5:23 pm

Vendor - TEL - Jashwant Gantyada

More
cb32846
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 35 more LEAHI-DD-FIRMWARE-LDT-3103-1

LDT-3103 addressed code review comments

- -8
- +21
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

5:23 pm

Vendor - TEL - Jashwant Gantyada

More
9e2f3b1
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 31 more

LDT-3103 addressed code review comments

- -6
- +19
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

5:18 pm

Vinayakam Mani and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3630-1
finished reviewing

5:12 pm

Vendor - TEL - Praneeth Bunne

More
ca27c61
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more LEAHI-DD-FIRMWARE-LDT-3630-1

Fix getFreshDialPumpInitialRpm function name and brief inputs comment

- -9
- +9
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

5:12 pm

Vendor - TEL - Praneeth Bunne

More
1f3075c
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 31 more

LDT-3750 cherry-picked ca27c61

- -9
- +9
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

4:53 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3630-1
commented on review

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-29 13:39 -0700