Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 27

Total Committers:	16
Last Commit:	08:40
Commits this week:	27

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 02 Apr

7:14 am

Dara Navaei

More
8bc8f0c
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 8 more

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

7:13 am

Dara Navaei

More
3e1af7c
changed 17 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 8 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Modes/FPModes/FPModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/FPModes/FPModeFault.c
- -2
- +2
/firmware/App/Modes/FPModes/FPModeFault.h
- History
- Source
- Diff
/firmware/App/Modes/FPModes/FPModeFault.h
- -2
- +2
/firmware/App/Modes/FPModes/FPModeStandby.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPModeStandby.c
- -2
- +2
/firmware/App/Modes/FPModes/FPModeStandby.h
- History
- Source
- Diff
/firmware/App/.../FPModes/FPModeStandby.h
- -2
- +2
/firmware/App/Modes/FPModes/FPOperationModes.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.c
- -2
- +2
/firmware/App/Modes/FPModes/FPOperationModes.h
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.h
- -2
- +2
/firmware/App/Modes/FPModes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.c
- -2
- +2
/firmware/App/Modes/FPModes/ModeGenPermeate.h
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.h
- -2
- +2
/firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/App/.../ModeGenPermeateDefeatured.c
- -2
- +2
/firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.h
- History
- Source
- Diff
/firmware/App/.../ModeGenPermeateDefeatured.h
- -2
- +2
/firmware/App/Modes/FPModes/ModePreGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.c
- -2
- +2
/firmware/App/Modes/FPModes/ModePreGenPermeate.h
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.h
- -2
- +2
/firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/.../ModePreGenPermeateDefeatured.c
- -2
- +2
/firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.h
- History
- Source
- Diff
/firmware/.../ModePreGenPermeateDefeatured.h
- -2
- +2
/firmware/App/Modes/FPModes/StateInletPressureCheck.c
- History
- Source
- Diff
/firmware/App/.../StateInletPressureCheck.c
- -2
- +2
/firmware/App/Modes/FPModes/StateInletPressureCheck.h
- History
- Source
- Diff
/firmware/App/.../StateInletPressureCheck.h
- -2
- +2
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

7:11 am

Raghu Kallala

7:11 am

Raghu Kallala

7:10 am

Raghu Kallala

More
83c9cd2
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 8 more

LDT-3603 merged into staging

Wednesday 01 Apr

2:36 pm

Vinayakam Mani

Done.

Done.

2:36 pm

Vinayakam Mani

More
0c85027
changed 3 files
LDT-1477-ultrafiltration---dd---04-dev--, develop LEAHI-DD-FIRMWARE-LDT-1477-1

LDT-1477 resolving merge conflicts

- -249
- +375
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -12
- +121
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -8
- +8
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

2:07 pm

Vinayakam Mani

More
8f8c4ba
changed 1 file
LDT-1477-ultrafiltration---dd---04-dev--, develop LEAHI-DD-FIRMWARE-LDT-1477-1

LDT-1477 code review comments incorporation

- -5
- +5
/firmware/App/Controllers/Ultrafiltration.c
- History
- Source
- Diff
/firmware/App/.../Ultrafiltration.c

12:26 pm

Vinayakam Mani , Michael Garthwaite and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3603-2
finished reviewing

11:34 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Algin "=" to be consistent with those below.

Algin "=" to be consistent with those below.

11:34 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Add blank line after declarations.

Add blank line after declarations.

11:33 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Add blank line after declarations.

Add blank line after declarations.

11:33 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Align comment.

Align comment.

11:32 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Is it time to restore?

Is it time to restore?

11:31 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Remove extra space after "=".

Remove extra space after "=".

11:29 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Are we going to restore this or not?

Are we going to restore this or not?

11:28 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Are we going to restore this or not?

Are we going to restore this or not?

11:28 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Are we going to restore this or not?

Are we going to restore this or not?

11:27 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Remove this.

Remove this.

11:26 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Remove this.

Remove this.

11:23 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Remove spaces before "=" or align "=".

Remove spaces before "=" or align "=".

11:21 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Fix comment alignment.

Fix comment alignment.

11:19 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Why are we commenting this out?

Why are we commenting this out?

11:18 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Is it time to restore now?

Is it time to restore now?

11:18 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-9
commented on review

Can we remove these 2 lines of code?

Can we remove these 2 lines of code?

11:13 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-3
commented on review

More implied boolean assignments.

More implied boolean assignments.

11:13 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-3
commented on review

Implied boolean assignment. Use ternary operator to assign TRUE or FALSE explicitly or don't initialize in declaration and use if else below to assign.

Implied boolean assignment. Use ternary operator to assign TRUE or FALSE explicitly or don't initialize in declaration and use if else below to assign.

10:36 am

Raghu Kallala

More
c9486db
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 7 more LEAHI-DD-FIRMWARE-LDT-3676-1

Fixed typo in header

- -1
- +1
/firmware/App/Modes/FPModes/FPOperationModes.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.c

10:28 am

Raghu Kallala

More
0629bf5
changed 3 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 7 more LEAHI-DD-FIRMWARE-LDT-3676-1

LDT-3779 added dialin test function to get boost pump installation status

- -0
- +21
/firmware/App/Modes/FPModes/FPOperationModes.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.c
- -0
- +7
/firmware/App/Modes/FPModes/FPOperationModes.h
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.h
- -0
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

8:56 am

Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-3676-1
joined review

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-14 09:09 -0700