Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 47

Total Committers:	16
Last Commit:	14:53
Commits this week:	47

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

4 hrs ago

Vendor - TEL - Sameer Poyil

More
1586844
changed 1 file
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

LDT-3978 addressed review comments

- -2
- +15
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c

4 hrs ago

Raghu Kallala

More
969f477
changed 2 files
LDT-4188-sw-fw-integration-to-run-a-trea, develop LEAHI-DD-FIRMWARE-LDT-4188-1

LDT-4188 addressed review comments

- -0
- +1
/firmware/App/Services/TDInterface.c
- History
- Source
- Diff
/firmware/App/Services/TDInterface.c
- -1
- +0
/firmware/App/Services/TDInterface.h
- History
- Source
- Diff
/firmware/App/Services/TDInterface.h

4 hrs ago

Raghu Kallala

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

4 hrs ago

Raghu Kallala

Idea is to have this in institutional records we implement it

Idea is to have this in institutional records we implement it

4 hrs ago

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

4 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4188-1
commented on review

If this is const, how will user add conversions (after 3rd value)?

If this is const, how will user add conversions (after 3rd value)?

4 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4188-1
commented on review

Remove extra blank line.

Remove extra blank line.

4 hrs ago

Vendor - TEL - Sameer Poyil

More
7a4c91c
changed 1 file
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

LDT-3978-addressed review comments

- -14
- +24
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c

4 hrs ago

Vendor - TEL - Jashwant Gantyada

More
ecd2045
changed 12 files
develop, feature/LDT-3963-dialysate-flow-rate---fw-implem LEAHI-DD-FIRMWARE-LDT-3963-1

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

- -16
- +21
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -4
- +9
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -1
- +1
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c
- -2
- +1
/firmware/App/Controllers/RinsePump.h
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.h
- -2
- +8
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -0
- +4
/firmware/App/Drivers/BloodLeakDriver.c
- History
- Source
- Diff
/firmware/App/Drivers/BloodLeakDriver.c
- -0
- +4
/firmware/App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.c
- -0
- +3
/firmware/App/Modes/ModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.c
- -0
- +4
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c
- -0
- +5
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c
- -2
- +1
/firmware/App/Services/AlarmMgmtDD.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmtDD.c
- -0
- +5
/firmware/App/Services/SystemCommDD.c
- History
- Source
- Diff
/firmware/App/Services/SystemCommDD.c

4 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3978-1
commented on review

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

4 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3978-1
commented on review

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

4 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3978-1
commented on review

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

5 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3978-1
commented on review

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

5 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3978-1
commented on review

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

5 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4188-1
commented on review

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change? Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let ...

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

6 hrs ago

Vendor - TEL - Sameer Poyil

More
d78a911
changed 1 file
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

LDT-3978 adreesing review comments

- -2
- +2
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c

6 hrs ago

Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-4188-1
joined review

7 hrs ago

Vendor - TEL - Sameer Poyil

More
cf37ec7
changed 1 file
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

LDT-3978 fixing compilation warning

- -1
- +0
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c

7 hrs ago

Vendor - TEL - Sameer Poyil

More
119b0ed
changed 2 files
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

LDT-3978 addressing review comments

- -55
- +60
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c
- -8
- +8
/firmware/App/Controllers/DryBiCart.h
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.h

Wednesday 29 Apr

5:41 pm

Vendor - TEL - Sameer Poyil

More
9646847
changed 3 files
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

LDT-3978 fixing compilation error

- -37
- +103
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c
- -1
- +2
/firmware/App/Controllers/DryBiCart.h
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.h
- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

1:49 pm

Vendor - TEL - Sameer Poyil

More
LEAHI-DD-FIRMWARE-LDT-4188-1
joined review

1:44 pm

Raghu Kallala

More
e91d5fb
changed 3 files
LDT-4188-sw-fw-integration-to-run-a-trea, develop LEAHI-DD-FIRMWARE-LDT-4188-1

LDT-4188 updated set pre-gen and gen dialysate function calls

- -1
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -35
- +97
/firmware/App/Services/TDInterface.c
- History
- Source
- Diff
/firmware/App/Services/TDInterface.c
- -3
- +6
/firmware/App/Services/TDInterface.h
- History
- Source
- Diff
/firmware/App/Services/TDInterface.h

1:36 pm

Vendor - TEL - Sameer Poyil

More
d2f5fe9
changed 1 file
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

LDT-3978 fix for compilation error

- -4
- +6
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c

12:45 pm

Dara Navaei

More
3215784
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -2
- +2
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

12:27 pm

Vendor - TEL - Sameer Poyil

More
fb44f74
changed 1 file
develop

Merge branch LDT-3980-dialysate-composition-dry-bicarb---fw-impl into develop

- -3
- +12
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c

12:25 pm

Vendor - TEL - Sameer Poyil

12:24 pm

Dara Navaei

More
1e02e4c
changed 1 file
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

12:24 pm

Dara Navaei

More
9e145b8
changed 1 file
LDT-3978-switch-chamber-f-conductive-lev, develop, staging LEAHI-DD-FIRMWARE-LDT-3978-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c

12:16 pm

Vendor - TEL - Sameer Poyil

More
b4646f2
changed 1 file
LDT-3978-switch-chamber-f-conductive-lev, develop, staging

Merge branch LDT-3980-dialysate-composition-dry-bicarb---fw-impl into staging

- -3
- +12
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c

12:14 pm

Vinayakam Mani and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3980-1
finished reviewing

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-30 15:31 -0700